git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Branchaud <marcnarc@xiplink.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org,
	"Stephen Haberman" <stephen@exigencecorp.com>,
	spearce@spearce.org, "Thomas Rast" <trast@student.ethz.ch>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>
Subject: Re: Heads up: major rebase -i -p rework coming up
Date: Mon, 26 Jan 2009 11:10:53 -0500	[thread overview]
Message-ID: <497DE08D.2030306@xiplink.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0901242056070.14855@racer>

Johannes Schindelin wrote:
> 
> - $sha1'
> 
> 	for merge and goto, if a $sha1 ends in a single quote, the 
> 	rewritten commit is substituted (if there is one)

I find this notation fairly unintuitive.  I'm more inclined to let users 
specify their own names for important parts of the rebase.

I guess that's what Junio's 'mark' command is for, but not having seen a 
proper explanation of 'mark', I suggest instead a more inline method: an 
'as' keyword.  Any command in a todo script can be followed (on the same 
line, before the SHA1 value) with 'as <name>' allowing <name> to appear 
later in the script to refer to the result of the earlier command.

So the script in the example becomes

	pick as start A
	pick C
	pick as bottom D
	goto start
	pick B
	merge bottom was E

I find that much easier to understand.  Especially when real SHA1 values 
are floating around everywhere, I think this notation will help users 
get things right.

This approach also allows a commit name "A" to consistently refer to the 
original commit, which I think also makes things easier for users.

		M.

  parent reply	other threads:[~2009-01-26 16:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24 20:25 Heads up: major rebase -i -p rework coming up Johannes Schindelin
2009-01-24 20:37 ` Junio C Hamano
2009-01-24 21:04   ` Johannes Schindelin
2009-01-24 21:09     ` Johannes Schindelin
2009-01-24 23:01     ` Junio C Hamano
2009-01-25  2:23       ` Johannes Schindelin
2009-01-26 16:21     ` Marc Branchaud
2009-01-24 22:47 ` Thomas Rast
2009-01-25  2:05   ` Johannes Schindelin
2009-01-25  2:25     ` Johannes Schindelin
2009-01-25 13:46       ` Jakub Narebski
2009-01-25 14:17         ` Johannes Schindelin
2009-01-25 15:07           ` Sverre Rabbelier
2009-01-25 15:24             ` Johannes Schindelin
2009-01-25 20:35               ` Junio C Hamano
2009-01-25 20:59                 ` Johannes Schindelin
2009-01-25 22:03                 ` Jakub Narebski
2009-01-25 23:29                   ` Johannes Schindelin
2009-02-03 10:05                     ` Nanako Shiraishi
2009-02-03 11:47                       ` Johannes Schindelin
2009-01-25 16:22           ` Jakub Narebski
2009-01-25 17:18             ` Björn Steinbrink
2009-01-26 16:10 ` Marc Branchaud [this message]
2009-01-27 15:21 ` Stephen Haberman
2009-01-27 18:08   ` Johannes Schindelin
2009-01-27 22:10   ` Nanako Shiraishi
2009-01-27 22:36     ` Stephen Haberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497DE08D.2030306@xiplink.com \
    --to=marcnarc@xiplink.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=stephen@exigencecorp.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).