From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] fsck: HEAD is part of refs
Date: Fri, 30 Jan 2009 10:27:22 +0100 [thread overview]
Message-ID: <4982C7FA.20107@viscovery.net> (raw)
In-Reply-To: <7veiylb1in.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> By default we looked at all refs but not HEAD. The only thing that
> made fsck not lose sight of comments that are only reachable from a
> detached HEAD was the reflog for the HEAD.
>
> This fixes it, with a new test.
[...]
> +test_expect_success setup '
> + test_commit A &&
> + git checkout HEAD^0 &&
> + test_commit B &&
> + git reflog expire --expire=now --all
> +'
> +
> +test_expect_success 'HEAD is part of refs' '
> + test 0 = $(git fsck | wc -l)
I'm scratching my head over this. This test succeeds even without the
change... (Tested with a34a9db.)
-- Hannes
next prev parent reply other threads:[~2009-01-30 9:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 6:24 Something weird is happening H. Peter Anvin
2009-01-29 6:56 ` Junio C Hamano
[not found] ` <20090129113846.GA10645@elte.hu>
2009-01-29 12:05 ` Ingo Molnar
2009-01-29 22:20 ` René Scharfe
2009-01-29 23:01 ` Daniel Barkalow
2009-01-31 14:39 ` [PATCH] merge: fix out-of-bounds memory access René Scharfe
2009-01-29 13:45 ` Something weird is happening Sverre Rabbelier
2009-02-01 1:31 ` Junio C Hamano
2009-01-29 10:50 ` Ingo Molnar
2009-01-29 10:52 ` Ingo Molnar
2009-01-29 21:45 ` Junio C Hamano
2009-01-29 22:10 ` H. Peter Anvin
2009-01-29 22:35 ` Ingo Molnar
[not found] ` <20090129224357.GA18471@elte.hu>
2009-01-29 22:47 ` H. Peter Anvin
2009-01-29 22:57 ` Junio C Hamano
2009-01-29 23:21 ` Linus Torvalds
2009-01-30 9:12 ` [PATCH 1/2] fsck: HEAD is part of refs Junio C Hamano
2009-01-30 9:27 ` Johannes Sixt [this message]
2009-02-01 0:53 ` Junio C Hamano
2009-01-30 16:47 ` Johannes Schindelin
2009-01-31 21:45 ` Nanako Shiraishi
2009-02-01 0:57 ` Junio C Hamano
2009-01-30 9:13 ` [PATCH 2/2] fsck: check loose objects from alternate object stores by default Junio C Hamano
2009-01-29 22:34 ` Something weird is happening Ingo Molnar
2009-01-29 22:36 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4982C7FA.20107@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hpa@zytor.com \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).