From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [fsck] What's cooking in git.git (Feb 2009, #02; Wed, 04)
Date: Thu, 05 Feb 2009 10:42:09 +0100 [thread overview]
Message-ID: <498AB471.1000609@viscovery.net> (raw)
In-Reply-To: <7vr62dk6ru.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> * jc/fsck (Fri Jan 30 02:44:13 2009 -0800) 5 commits
> - fsck: revert --quick to the default and introduce --medium
> - fsck: three levels of validation
> - verify-pack: add --quick
> - verify_pack(): allow a quicker verification for a pack with
> version 2 idx
> - pack-check.c: minor formatting fix to match coding style
>
> I haven't heard anything positive nor negative about this series. I think
> the tip two commits should be squashed (and perhaps the option parser
> cleaned up as suggested on the list).
If you *do* squash the top two commits due to the surprisingly expensive
--medium check level, what is the whole point of the series?
That is, if I can have a reasonably thorough check only by passing an
option to 'git fsck', then why would I want to choose --medium when I can
have --full for only a 30% higher price (according to the timings you gave)?
-- Hannes
next prev parent reply other threads:[~2009-02-05 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 1:32 What's cooking in git.git (Feb 2009, #02; Wed, 04) Junio C Hamano
2009-02-05 9:42 ` Johannes Sixt [this message]
2009-02-06 18:15 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498AB471.1000609@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).