From: Michael J Gruber <git@drmicha.warpmail.net>
To: unlisted-recipients:; (no To-header on input)
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] git notes show: handle empty notes gracefully
Date: Fri, 06 Feb 2009 16:37:07 +0100 [thread overview]
Message-ID: <498C5923.8070009@drmicha.warpmail.net> (raw)
In-Reply-To: <1233933543-28407-1-git-send-email-git@drmicha.warpmail.net>
Michael J Gruber venit, vidit, dixit 06.02.2009 16:19:
> "git notes show" barfs when there is no note to show. This introduces a
> test (yes, a test!) and, in a second round, reacts more gracefully to
> empty notes and adjust the expected test output accordingly.
>
> Note that in both cases (before/after the patch) the return code is
> non-zero: It's 128 in the ungraceful case, 1 when "dieing gracefully",
> uhm...
>
> Michael J Gruber (2):
> git notes show: test empty notes
> handle empty notes gracefully
>
> git-notes.sh | 2 ++
> t/t3301-notes.sh | 5 +++++
> 2 files changed, 7 insertions(+), 0 deletions(-)
Uhm, I'm about 1 hour late with my afternoon coffee, and I'm afraid that
shows:
1) I meant "bark", not "barf", although both make sense here.
2) When did "format.signoff = true" in config stop working? OK, it never
did. So please consider this (anyway trivial series):
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
prev parent reply other threads:[~2009-02-06 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 15:19 [PATCH 0/2] git notes show: handle empty notes gracefully Michael J Gruber
2009-02-06 15:19 ` [PATCH 1/2] git notes show: test empty notes Michael J Gruber
2009-02-06 15:19 ` [PATCH 2/2] handle empty notes gracefully Michael J Gruber
2009-02-06 15:38 ` Johannes Schindelin
2009-02-06 15:49 ` Johannes Sixt
2009-02-06 15:50 ` Michael J Gruber
2009-02-06 15:36 ` [PATCH 1/2] git notes show: test empty notes Johannes Schindelin
2009-02-06 15:42 ` Michael J Gruber
2009-02-06 15:37 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498C5923.8070009@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).