From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] handle empty notes gracefully
Date: Fri, 06 Feb 2009 16:49:14 +0100 [thread overview]
Message-ID: <498C5BFA.7030107@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0902061636320.7377@intel-tinevez-2-302>
Johannes Schindelin schrieb:
> On Fri, 6 Feb 2009, Michael J Gruber wrote:
>> +test_expect_success 'handle empty notes gracefully' '
>> git notes show || test 1 = $?
>
> Completely forgot to mention that I think you want to use test_must_fail
> here.
Wouldn't work. We want to differentiate between different exit codes. But
after test_must_fail the exit code is gone. In this simple case this
should work:
git notes show; test 1 = $?
-- Hannes
next prev parent reply other threads:[~2009-02-06 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 15:19 [PATCH 0/2] git notes show: handle empty notes gracefully Michael J Gruber
2009-02-06 15:19 ` [PATCH 1/2] git notes show: test empty notes Michael J Gruber
2009-02-06 15:19 ` [PATCH 2/2] handle empty notes gracefully Michael J Gruber
2009-02-06 15:38 ` Johannes Schindelin
2009-02-06 15:49 ` Johannes Sixt [this message]
2009-02-06 15:50 ` Michael J Gruber
2009-02-06 15:36 ` [PATCH 1/2] git notes show: test empty notes Johannes Schindelin
2009-02-06 15:42 ` Michael J Gruber
2009-02-06 15:37 ` [PATCH 0/2] git notes show: handle empty notes gracefully Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498C5BFA.7030107@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).