From: Yann Simon <yann.simon.fr@gmail.com>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Cc: git <git@vger.kernel.org>
Subject: [PATCH JGIT] Use previous author when amending a commit
Date: Mon, 09 Feb 2009 10:30:57 +0100 [thread overview]
Message-ID: <498FF7D1.8030905@gmail.com> (raw)
In the commit dialog, when amending the commit, the author of the
previous commit is proposed as default in the author field.
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../egit/ui/internal/actions/CommitAction.java | 5 ++++-
.../egit/ui/internal/dialogs/CommitDialog.java | 12 ++++++++++++
2 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
index ae26770..d30172f 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
@@ -118,8 +118,11 @@ public void run(IAction act) {
commitDialog.setFileList(files);
commitDialog.setAuthor(author);
- if (previousCommit != null)
+ if (previousCommit != null) {
commitDialog.setPreviousCommitMessage(previousCommit.getMessage());
+ PersonIdent previousAuthor = previousCommit.getAuthor();
+ commitDialog.setPreviousAuthor(previousAuthor.getName() + " <" + previousAuthor.getEmailAddress() + ">");
+ }
if (commitDialog.open() != IDialogConstants.OK_ID)
return;
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
index fede948..b122fb8 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
@@ -175,6 +175,7 @@ public void keyPressed(KeyEvent arg0) {
amendingButton.setSelection(amending);
amendingButton.setEnabled(false); // if already set, don't allow any changes
commitText.setText(previousCommitMessage);
+ authorText.setText(previousAuthor);
} else if (!amendAllowed) {
amendingButton.setEnabled(false);
}
@@ -189,6 +190,7 @@ public void widgetSelected(SelectionEvent arg0) {
if (curText.length() > 0)
curText += "\n"; //$NON-NLS-1$
commitText.setText(curText + previousCommitMessage);
+ authorText.setText(previousAuthor);
}
}
@@ -334,6 +336,7 @@ public void setCommitMessage(String s) {
private String commitMessage = ""; //$NON-NLS-1$
private String author = null;
+ private String previousAuthor = null;
private boolean signedOff = false;
private boolean amending = false;
private boolean amendAllowed = true;
@@ -470,6 +473,15 @@ public void setAuthor(String author) {
}
/**
+ * Pre-set the previous author if amending the commit
+ *
+ * @param previousAuthor
+ */
+ public void setPreviousAuthor(String previousAuthor) {
+ this.previousAuthor = previousAuthor;
+ }
+
+ /**
* @return whether to auto-add a signed-off line to the message
*/
public boolean isSignedOff() {
--
1.6.0.4
next reply other threads:[~2009-02-09 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 9:30 Yann Simon [this message]
2009-02-09 15:29 ` [PATCH JGIT] Use previous author when amending a commit Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498FF7D1.8030905@gmail.com \
--to=yann.simon.fr@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox