From: Johannes Sixt <j.sixt@viscovery.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support
Date: Wed, 11 Feb 2009 12:30:13 +0100 [thread overview]
Message-ID: <4992B6C5.3010609@viscovery.net> (raw)
In-Reply-To: <81b0412b0902110253g2288419eha4037f22f6286ea4@mail.gmail.com>
Alex Riesen schrieb:
> 2009/2/11 Johannes Sixt <j.sixt@viscovery.net>:
>> Alex Riesen schrieb:
>>> I'm honestly sorry for my contributions. They seem to be exclusively
>>> in the "make Git work in Windows" area. Depressing.
>>>
>>> t/t3400-rebase.sh | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>> Very interesting. This test works unmodified here. On the other hand, I
>> have to skip the entire t4129-apply-samemode.sh.
>>
>
> hmm... These seem to work here. I have to use Cygwin. Do you use the
> native port?
Yes. And the reason why the test does not fail here is because the mode
change is outright ignored, and the test doesn't check whether the result
meets the expectations.
-- Hannes
prev parent reply other threads:[~2009-02-11 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 9:51 [PATCH] Disable filemode rebase tests in t3400-rebase.sh if no filesystem mode support Alex Riesen
2009-02-11 10:09 ` Junio C Hamano
2009-02-11 11:05 ` Alex Riesen
2009-02-11 10:09 ` Johannes Sixt
2009-02-11 10:53 ` Alex Riesen
2009-02-11 11:30 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4992B6C5.3010609@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).