From: Johannes Sixt <j.sixt@viscovery.net>
To: Eric Kidd <git@randomhacks.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-filter-branch: Add more error-handling
Date: Wed, 11 Feb 2009 16:36:31 +0100 [thread overview]
Message-ID: <4992F07F.2080005@viscovery.net> (raw)
In-Reply-To: <4992E79D.10208@viscovery.net>
Johannes Sixt schrieb:
>> @@ -483,7 +486,7 @@ test -z "$ORIG_GIT_INDEX_FILE" || {
>> }
>>
>> if [ "$(is_bare_repository)" = false ]; then
>> - git read-tree -u -m HEAD
>> + git read-tree -u -m HEAD || die "Unable to checkout rewritten tree"
>
> Here you shouldn't die.
I take this back. I was distracted by the 'exit $ret' that is visible in
the context:
>> fi
>>
>> exit $ret
But this exit statement is pointless: ret is initialized to zero and never
changed.
-- Hannes
next prev parent reply other threads:[~2009-02-11 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 14:09 [PATCH] git-filter-branch: Add more error-handling Eric Kidd
2009-02-11 14:58 ` Johannes Sixt
2009-02-11 15:36 ` Johannes Sixt [this message]
2009-02-11 15:24 ` Johannes Schindelin
2009-02-11 17:15 ` [PATCH v2] filter-branch: " Eric Kidd
2009-02-11 19:03 ` Junio C Hamano
2009-02-11 19:34 ` Eric Kidd
2009-02-11 20:03 ` [PATCHv3] " Eric Kidd
2009-02-11 20:48 ` Johannes Schindelin
2009-02-11 21:00 ` Eric Kidd
2009-02-11 21:10 ` [PATCHv4] " Eric Kidd
2009-02-11 21:30 ` [PATCH v2] " Nanako Shiraishi
2009-02-11 22:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4992F07F.2080005@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@randomhacks.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).