From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ted Pavlic <ted@tedpavlic.com>
Subject: Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to
 match git convention
Date: Wed, 11 Feb 2009 11:36:08 -0500
Message-ID: <4992FE78.6000206@tedpavlic.com>
References: <1234366634-17900-1-git-send-email-ted@tedpavlic.com> <1234366634-17900-2-git-send-email-ted@tedpavlic.com> <1234366634-17900-3-git-send-email-ted@tedpavlic.com> <20090211162432.GF30949@spearce.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: git <git@vger.kernel.org>, gitster <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
X-From: git-owner@vger.kernel.org Wed Feb 11 17:37:54 2009
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1LXI5o-0002dB-Tm
	for gcvg-git-2@gmane.org; Wed, 11 Feb 2009 17:37:45 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754884AbZBKQgR (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 11 Feb 2009 11:36:17 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754404AbZBKQgR
	(ORCPT <rfc822;git-outgoing>); Wed, 11 Feb 2009 11:36:17 -0500
Received: from gallifrey.ece.ohio-state.edu ([164.107.167.66]:49773 "EHLO
	gallifrey.ece.ohio-state.edu" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754158AbZBKQgQ (ORCPT
	<rfc822;git@vger.kernel.org>); Wed, 11 Feb 2009 11:36:16 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id BE2F280D8088;
	Wed, 11 Feb 2009 11:29:45 -0500 (EST)
X-Virus-Scanned: amavisd-new at gallifrey.ece.ohio-state.edu
Received: from gallifrey.ece.ohio-state.edu ([127.0.0.1])
	by localhost (gallifrey.ece.ohio-state.edu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id o0pvdITBGpuV; Wed, 11 Feb 2009 11:29:45 -0500 (EST)
Received: from tedbook.mshome.net (tedpc.ece.ohio-state.edu [164.107.164.122])
	by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id A270E80D8036;
	Wed, 11 Feb 2009 11:29:45 -0500 (EST)
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051201 Thunderbird/1.5 Mnenhy/0.7.3.0
In-Reply-To: <20090211162432.GF30949@spearce.org>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/109441>

> NAK.
>
> This script only runs in bash.  bash supports [...].  The
> prevailing convention in the script is to use [...].  Only
> 4 tests inside of __git_ps1 use "test", the rest of the code
> is using [...].

So this trumps Documentation/CodingGuidelines, which says:

  - We prefer "test" over "[ ... ]".

?

Thanks --
Ted

-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.