From: Johannes Sixt <j6t@kdbg.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com,
Steffen Prohaska <prohaska@zib.de>
Subject: Re: [PATCH 1/2] Introduce the function strip_path_suffix()
Date: Wed, 18 Feb 2009 23:27:16 +0100 [thread overview]
Message-ID: <499C8B44.1020106@kdbg.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0902182211550.10279@pacific.mpi-cbg.de>
Johannes Schindelin schrieb:
> On Wed, 18 Feb 2009, Johannes Sixt wrote:
>> Johannes Schindelin schrieb:
>>> strip_path_suffix("C:\\msysgit/\\libexec\\git-core",
>>> "libexec///git-core", &prefix)
>>>
>>> will set prefix to "C:\\msysgit" and return 0.
>> But you implemented it so that prefix is actually "C:\\msysgit/\\"
>> (unless, of course, I'm reading the code wrong).
>
> This is supposed to handle that case:
>
> *prefix = xstrndup(path, chomp_trailing_dir_sep(path, path_len));
Ah, I missed that final call of chomp_trailing_dir_sep.
-- Hannes
next prev parent reply other threads:[~2009-02-18 22:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 15:10 [PATCH 0/2] RUNTIME_PREFIX enhancements Johannes Schindelin
2009-02-18 15:11 ` [PATCH 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-18 19:39 ` Johannes Sixt
2009-02-18 21:13 ` Johannes Schindelin
2009-02-18 22:27 ` Johannes Sixt [this message]
2009-02-18 23:18 ` Johannes Schindelin
2009-02-19 19:10 ` [PATCH v2 0/2] RUNTIME_PREFIX enhancements Johannes Schindelin
2009-02-19 19:10 ` [PATCH v2 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-19 20:12 ` Johannes Schindelin
2009-02-19 20:26 ` Johannes Sixt
2009-02-19 20:44 ` Johannes Schindelin
2009-02-19 19:10 ` [PATCH v2 2/2] system_path(): simplify using strip_path_suffix(), and add suffix "git" Johannes Schindelin
2009-02-19 20:39 ` Johannes Sixt
2009-02-19 20:48 ` Johannes Schindelin
2009-02-20 8:35 ` Junio C Hamano
2009-02-18 15:11 ` [PATCH " Johannes Schindelin
2009-02-18 19:38 ` [PATCH 0/2] RUNTIME_PREFIX enhancements Johannes Sixt
2009-02-18 21:11 ` Johannes Schindelin
2009-02-18 22:52 ` Johannes Sixt
2009-02-18 23:19 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499C8B44.1020106@kdbg.org \
--to=j6t@kdbg.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).