git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] RUNTIME_PREFIX enhancements
@ 2009-02-18 15:10 Johannes Schindelin
  2009-02-18 15:11 ` [PATCH 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
                   ` (2 more replies)
  0 siblings, 3 replies; 20+ messages in thread
From: Johannes Schindelin @ 2009-02-18 15:10 UTC (permalink / raw)
  To: git, gitster; +Cc: Johannes Sixt, Steffen Prohaska

When I ran "make" in msysGit's /git/, I was greeted by a pretty unfriendly 
message about a RUNTIME_PREFIX that could not be determined.

Not understanding the code in exec_cmd.c, I went back to a comment I made 
to one of the iterations of the RUNTIME_PREFIX patch series (back when I 
spent a considerable amount of time to understand the code), and turned it 
into a patch myself.

I hope you will agree that the code introduced in 1/2 is more 
understandable than what is removed in 2/2 in favor of the former.

The real meat comes in patch 2/2:

The problem is that Windows will look in the current directory before 
looking in the PATH when it tries to execute a program.  So it will find 
the executable C:\msysgit\git\git.exe and be unable to strip the suffices 
"libexec/git-core" or "bin".

I just added "git" (which should not hurt other users, but instead help 
them if they did not install Git but run it in-place).

Johannes Schindelin (2):
  Introduce the function strip_path_suffix()
  system_path(): simplify using strip_path_suffix(), and add suffix
    "git"

 cache.h    |    2 ++
 exec_cmd.c |   32 +++-----------------------------
 path.c     |   33 +++++++++++++++++++++++++++++++++
 3 files changed, 38 insertions(+), 29 deletions(-)

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2009-02-20  8:38 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 15:10 [PATCH 0/2] RUNTIME_PREFIX enhancements Johannes Schindelin
2009-02-18 15:11 ` [PATCH 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-18 19:39   ` Johannes Sixt
2009-02-18 21:13     ` Johannes Schindelin
2009-02-18 22:27       ` Johannes Sixt
2009-02-18 23:18         ` Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 0/2] RUNTIME_PREFIX enhancements Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-19 20:12       ` Johannes Schindelin
2009-02-19 20:26       ` Johannes Sixt
2009-02-19 20:44         ` Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 2/2] system_path(): simplify using strip_path_suffix(), and add suffix "git" Johannes Schindelin
2009-02-19 20:39       ` Johannes Sixt
2009-02-19 20:48         ` Johannes Schindelin
2009-02-20  8:35         ` Junio C Hamano
2009-02-18 15:11 ` [PATCH " Johannes Schindelin
2009-02-18 19:38 ` [PATCH 0/2] RUNTIME_PREFIX enhancements Johannes Sixt
2009-02-18 21:11   ` Johannes Schindelin
2009-02-18 22:52     ` Johannes Sixt
2009-02-18 23:19       ` Johannes Schindelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).