git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Fix file name pattern in .gitattributes.
Date: Tue, 24 Feb 2009 10:25:57 +0100	[thread overview]
Message-ID: <49A3BD25.3000706@viscovery.net> (raw)
In-Reply-To: <7vskm4jkbk.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:
> Johannes Sixt <j6t@kdbg.org> writes:
> 
>> The pattern for the *.po files was anchored at the repository's root, but
>> this would match the files only in the git-gui repository itself, but
>> not in the version that is subtree-merged into git.git.
>>
>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>> ---
>>  .gitattributes |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/.gitattributes b/.gitattributes
>> index f96112d..c69f4a0 100644
>> --- a/.gitattributes
>> +++ b/.gitattributes
>> @@ -1,3 +1,3 @@
>>  *           encoding=US-ASCII
>>  git-gui.sh  encoding=UTF-8
>> -/po/*.po    encoding=UTF-8
>> +po/*.po     encoding=UTF-8
> 
> Hmm, really?

No, not really. =:{

I observed some strangeness with gitk. But it turned out that this was an
old development version that got accidentally installed somewhere in $PATH.

Sorry for the noise.

-- Hannes

  reply	other threads:[~2009-02-24  9:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  8:01 [PATCH] git-gui: Fix file name pattern in .gitattributes Johannes Sixt
2009-02-24  8:44 ` Junio C Hamano
2009-02-24  9:25   ` Johannes Sixt [this message]
2009-02-24 17:33     ` Junio C Hamano
2009-02-25  7:54       ` [PATCH 1/2] gitattributes.txt: Path matching rules are explained in gitignore.txt Johannes Sixt
2009-02-25  8:00         ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A3BD25.3000706@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).