From: Ted Pavlic <ted@tedpavlic.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Marius Storm-Olsen <marius@trolltech.com>,
Marius Storm-Olsen <git@storm-olsen.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH] Add bare repository indicator for __git_ps1
Date: Tue, 24 Feb 2009 09:25:54 -0500 [thread overview]
Message-ID: <49A40372.2060600@tedpavlic.com> (raw)
In-Reply-To: <7vab8cpqgl.fsf@gitster.siamese.dyndns.org>
> Reverting GIT_DIR! ugliness is certainly a possibility. As long as people
> who chdir into there are the only ones who suffer from the ugliness I do
> not particularly care that much, though ;-)
>
> Will apply anyway.
I only added the "GIT_DIR!" on the advice of Junio, who suggested a
"danger" flag. I asked for suggestions on replacement text.
Keep in mind that "BARE:master" doesn't make much sense. If you're in a
git dir, you don't have a working directory. "BARE" alone makes sense.
Personally, I think it makes more sense to submit a patch that changes
"GIT_DIR!" to "BARE" in the bare case (and doesn't print any branch).
--Ted
--
Ted Pavlic <ted@tedpavlic.com>
Please visit my ALS association page:
http://web.alsa.org/goto/tedpavlic
My family appreciates your support in the fight to defeat ALS.
next prev parent reply other threads:[~2009-02-24 14:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 14:48 [PATCH] Add bare repository indicator for __git_ps1 Marius Storm-Olsen
2009-02-21 14:53 ` Marius Storm-Olsen
2009-02-21 19:29 ` Junio C Hamano
2009-02-21 19:43 ` Marius Storm-Olsen
2009-02-22 16:49 ` Junio C Hamano
2009-02-23 7:52 ` Marius Storm-Olsen
2009-02-23 15:42 ` Shawn O. Pearce
2009-02-23 16:03 ` Marius Storm-Olsen
2009-02-23 16:16 ` Shawn O. Pearce
2009-02-23 18:55 ` Marius Storm-Olsen
2009-02-24 1:35 ` Junio C Hamano
2009-02-24 14:25 ` Ted Pavlic [this message]
2009-02-24 14:46 ` Marius Storm-Olsen
2009-02-24 15:39 ` Ted Pavlic
2009-02-24 17:01 ` Junio C Hamano
2009-02-24 19:47 ` Marius Storm-Olsen
2009-02-25 6:08 ` Junio C Hamano
2009-02-25 6:46 ` Marius Storm-Olsen
-- strict thread matches above, loose matches on Subject: below --
2009-02-20 14:56 Marius Storm-Olsen
2009-02-20 16:35 ` Johannes Schindelin
2009-02-20 16:46 ` Thomas Rast
2009-02-20 17:13 ` Michael J Gruber
2009-02-20 22:04 ` Marius Storm-Olsen
2009-02-20 16:39 ` Michael J Gruber
2009-02-20 21:55 ` Marius Storm-Olsen
2009-02-20 17:06 ` Ted Pavlic
2009-02-20 22:00 ` Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A40372.2060600@tedpavlic.com \
--to=ted@tedpavlic.com \
--cc=git@storm-olsen.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marius@trolltech.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).