From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Peter Rosin <peda@lysator.liu.se>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git filter-branch: Process commits in --date-order
Date: Tue, 03 Mar 2009 08:41:46 +0100 [thread overview]
Message-ID: <49ACDF3A.1090309@viscovery.net> (raw)
In-Reply-To: <7vbpsjl97d.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> I am wondering if it even makes sense to allow users to disable
> topological ordering.
>
> Doesn't filter-branch have the same "child commits build on top of parent
> commits" dependency as fast-export has? And didn't you guys fix
> fast-export recently?
Doesn't --date-order have the same guarantee as --topo-order with respect
to parents and children, only that commits that can be rearranged such
that the guarantee remains are emitted in date order?
Anyway, the patch is unnecessary: If --date-order is needed, it can be
passed on the command line; this will override --topo-order.
-- Hannes
prev parent reply other threads:[~2009-03-03 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 23:10 [PATCH] git filter-branch: Process commits in --date-order Peter Rosin
2009-03-03 0:28 ` Johannes Schindelin
2009-03-03 0:39 ` Peter Rosin
2009-03-03 0:51 ` Junio C Hamano
2009-03-03 7:41 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ACDF3A.1090309@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).