Git development
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: John Tapsell <johnflux@gmail.com>
Cc: John Dlugosz <JDlugosz@tradestation.com>, git@vger.kernel.org
Subject: Re: Help designing work flow
Date: Mon, 09 Mar 2009 14:28:52 +0100	[thread overview]
Message-ID: <49B51994.1040200@op5.se> (raw)
In-Reply-To: <43d8ce650903090622j51b73801gb4be62a7f50029a4@mail.gmail.com>

John Tapsell wrote:
> 2009/3/9 Andreas Ericsson <ae@op5.se>:
>> John Tapsell wrote:
> 
>> Not really. If bugs are in "unrelated" areas (if the topic changed some
>> API without changing its' other callers, fe), you can backstep between
>> each commit on the merged branch, remerge that commit (instead of the
>> tip) and then run the tests again.
> 
> Doing that manually?  Sounds really complicated, especially if the
> merge is nontrivial.
> 

Well, using git bisect should work.

>> But really, such bugs should have
>> been detected prior to merging the branch, and in any case "git bisect"
>> will find the commit that introduced the bug for you either way.
> 
> How will you detect bugs that arise from merging two trees, before you
> merge them?
> 

Assuming you don't start each topic-branch from a completely empty tree
and that you have *some* tests, you can run those tests at every single
commit just as if you had done those on the 'master' branch. API changes
that break things should break earlier, unless another branch made those
changes.

Aside from that, it's quite simple to run tests before publishing the
results of the merge, and it's absolutely trivial to undo the merge
in case tests don't pass.

>> For next time, please cut away those parts of the email you didn't
>> reply to. I had to scroll down to the bottom to make sure you hadn't
>> written more.
> 
> I'll try sorry.  Most email clients will hide the quoted text - there
> might be an option for that in your client?
> 

I'm sure there is, but then I wouldn't have seen what you were replying
to, so that's not a very good option. In the space between me sending
and you replying, I wrote six other emails. Keeping track of them all
in my head is not something I'm prepared to even consider trying.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

  reply	other threads:[~2009-03-09 13:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 20:17 Help designing work flow John Dlugosz
2009-03-09 10:55 ` Andreas Ericsson
2009-03-09 11:44   ` John Tapsell
2009-03-09 12:27     ` Andreas Ericsson
2009-03-09 13:22       ` John Tapsell
2009-03-09 13:28         ` Andreas Ericsson [this message]
2009-03-09 15:36   ` John Dlugosz
2009-03-26 15:38   ` John Dlugosz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B51994.1040200@op5.se \
    --to=ae@op5.se \
    --cc=JDlugosz@tradestation.com \
    --cc=git@vger.kernel.org \
    --cc=johnflux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox