From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2009, #03; Wed, 11)
Date: Thu, 12 Mar 2009 21:22:50 +0100 [thread overview]
Message-ID: <49B96F1A.3060001@lsrfire.ath.cx> (raw)
In-Reply-To: <7vvdqg5s17.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Tonight's 'pu' does not pass its self-test and it is expected; I won't be
> fixing it and I'm going to bed now.
This fixes a segfault:
diff --git a/remote.c b/remote.c
index 68c1a84..ea1841e 100644
--- a/remote.c
+++ b/remote.c
@@ -655,9 +655,9 @@ struct remote *remote_get(const char *name)
struct remote *ret;
int name_given = 0;
read_config();
- if (name || strcmp(name, "-"))
+ if (name && strcmp(name, "-"))
name_given = 1;
else {
name = default_remote_name;
name_given = explicit_default_remote_name;
next prev parent reply other threads:[~2009-03-12 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 9:26 What's cooking in git.git (Mar 2009, #03; Wed, 11) Junio C Hamano
2009-03-11 9:59 ` Felipe Contreras
2009-03-11 15:01 ` Jay Soffian
2009-03-11 22:37 ` Thomas Rast
2009-03-11 22:40 ` [PATCH] send-email: test --no-thread --in-reply-to combination Thomas Rast
2009-03-12 20:22 ` René Scharfe [this message]
2009-03-12 20:43 ` What's cooking in git.git (Mar 2009, #03; Wed, 11) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B96F1A.3060001@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).