From: Johannes Sixt <j.sixt@viscovery.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
layer <layer@known.net>,
git@vger.kernel.org
Subject: Re: [PATCH] disable post-checkout test on Cygwin
Date: Tue, 17 Mar 2009 17:59:09 +0100 [thread overview]
Message-ID: <49BFD6DD.1010800@viscovery.net> (raw)
In-Reply-To: <7vprggqeh2.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
>> It is broken because of the tricks we have to play with
>> lstat to get the bearable perfomance out of the call.
>> Sadly, it disables access to Cygwin's executable attribute,
>> which Windows filesystems do not have at all.
>
> Hmm, perhaps when checking hooks to see if they are executable, Cygwin
> port should avoid using the "tricks"? Compared to paths inside the
> worktree the number of hooks is a lot smaller, no?
Hmm. Nowadays, we run hooks through run_hook() in run_command.c. It uses
access(..., X_OK), not lstat(). We don't play games with access(), do we?
-- Hannes
next prev parent reply other threads:[~2009-03-17 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 16:26 [PATCH] disable post-checkout test on Cygwin Alex Riesen
2009-03-17 16:52 ` Junio C Hamano
2009-03-17 16:59 ` Johannes Sixt [this message]
2009-03-17 20:28 ` Alex Riesen
2009-03-17 20:42 ` Junio C Hamano
2009-03-17 21:38 ` [PATCH] Define a version of lstat(2) specially for copy operation Alex Riesen
2009-03-18 3:17 ` Mark Levedahl
2009-03-18 7:22 ` Alex Riesen
2009-03-18 7:41 ` Junio C Hamano
2009-03-18 7:56 ` Johannes Sixt
2009-03-18 9:30 ` Junio C Hamano
2009-03-18 10:14 ` Johannes Sixt
2009-03-18 18:56 ` Junio C Hamano
2009-03-17 20:34 ` [PATCH] disable post-checkout test on Cygwin Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BFD6DD.1010800@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=layer@known.net \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).