git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: git@vger.kernel.org
Cc: gitster@pobox.com, spearce@spearce.org, peff@peff.net
Subject: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Date: Sun, 22 Mar 2009 16:49:05 +0100	[thread overview]
Message-ID: <49C65DF1.8030608@web.de> (raw)

When checking out or cloning via git gui, the post-checkout
hook is not called. This is a bit unexpected ...

The reason is that git gui uses git read-tree with the -u
option and not git checkout and git clone. I changed git
read-tree to call the post-checkout hook when called with
-u and it seems to solve the problem. I would make a patch
for that if you want.

But is this the right way to do this? Seems like we could
surprise some users of git read-tree with this change in
behaviour.

(I hope i cc'ed the right people this time ;-)

Jens

             reply	other threads:[~2009-03-22 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 15:49 Jens Lehmann [this message]
2009-03-22 22:33 ` [RFC] git gui doesn't call post-checkout hook on checkout or clone Jeff King
2009-03-23  0:18   ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C65DF1.8030608@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).