From: Michael J Gruber <git@drmicha.warpmail.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/WIP 1/2] Documentation: fix minor inconsistency
Date: Mon, 23 Mar 2009 15:56:38 +0100 [thread overview]
Message-ID: <49C7A326.2050403@drmicha.warpmail.net> (raw)
In-Reply-To: <vpq7i2g9u4m.fsf@bauges.imag.fr>
Matthieu Moy venit, vidit, dixit 23.03.2009 15:44:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> While we don't always write out commands in full (`git command`) we
>> should do it consistently in adjacent paragraphs.
>
>> - If set to true or "refuse", receive-pack will deny a ref update
>> + If set to true or "refuse", git-receive-pack will deny a ref update
>
> Then, shouldn't this be `git receive-pack` ?
It should be git-receive-pack in the first patch (adding missing git in
the same style as used there), `git-receive-pack` in the second patch
(implementation of step 1) and `git receive-pack` in step 2 (the
un-dashifying step), which comes later, just as outlined in the cover
letter. Mixing these steps into one patch would be a reviewing
nightmare. Squashing those two patches (constituting step 1 for the
first few files) would be fine.
Michael
next prev parent reply other threads:[~2009-03-23 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 14:28 [RFC/WIP 0/2] Documentation clean-up: git commands Michael J Gruber
2009-03-23 14:28 ` [RFC/WIP 1/2] Documentation: fix minor inconsistency Michael J Gruber
2009-03-23 14:28 ` [RFC/WIP 2/2] Documentation: format git commands consistently Michael J Gruber
2009-03-23 14:44 ` [RFC/WIP 1/2] Documentation: fix minor inconsistency Matthieu Moy
2009-03-23 14:56 ` Michael J Gruber [this message]
2009-03-23 14:31 ` [RFC/WIP 0/2] Documentation clean-up: git commands Michael J Gruber
2009-03-23 16:22 ` Junio C Hamano
2009-03-23 16:35 ` Michael J Gruber
2009-03-23 23:13 ` Chris Johnsen
2009-03-24 3:34 ` Jeff King
2009-03-24 8:24 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C7A326.2050403@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).