From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Bert Wesarg <bert.wesarg@googlemail.com>,
Petr Baudis <pasky@suse.cz>,
git@vger.kernel.org, martin f krafft <madduck@debian.org>,
Marc Kleine-Budde <m.kleine-budde@pengutronix.de>
Subject: Re: [PATCH TopGit] hooks/pre-commit.sh: fix bashism
Date: Thu, 26 Mar 2009 10:29:54 +0100 [thread overview]
Message-ID: <49CB4B12.3020408@pengutronix.de> (raw)
In-Reply-To: <20090326090009.GA7570@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]
Uwe Kleine-König wrote:
> This was introduced in fcb488d51e72c7414f9beb40ad06bf529b8b38dc.
> A similar fix was suggested by martin f krafft, too.
Works here on ubuntu bin /bin/sh is a link to /bin/dash
> Reported-by: Bert Wesarg <bert.wesarg@googlemail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Hello,
>
> this should fix the issue now.
>
> If I don't get negative feed back I will push this change later today.
> I'm open for acks, too.
>
> Best regards and thanks
> Uwe
>
> hooks/pre-commit.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
> index a12cfa6..9d677e9 100644
> --- a/hooks/pre-commit.sh
> +++ b/hooks/pre-commit.sh
> @@ -20,7 +20,7 @@ tg_util
> if head_=$(git symbolic-ref -q HEAD); then
> case "$head_" in
> refs/heads/*)
> - git rev-parse -q --verify "${head_/#refs\/heads/refs\/top-bases}" >/dev/null || exit 0;;
> + git rev-parse -q --verify "refs/top-bases${head_#refs/heads}" >/dev/null || exit 0;;
> *)
> exit 0;;
> esac
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Linux Solutions for Science and Industry | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2009-03-26 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 11:43 [TopGit PATCH] hooks/pre-commit.sh: fix it again Bert Wesarg
2009-03-25 12:17 ` martin f krafft
2009-03-25 12:20 ` Uwe Kleine-König
2009-03-25 12:24 ` Bert Wesarg
2009-03-25 21:44 ` Uwe Kleine-König
2009-03-26 9:00 ` [PATCH TopGit] hooks/pre-commit.sh: fix bashism Uwe Kleine-König
2009-03-26 9:29 ` Marc Kleine-Budde [this message]
2009-03-26 14:21 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CB4B12.3020408@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=m.kleine-budde@pengutronix.de \
--cc=madduck@debian.org \
--cc=pasky@suse.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).