[PATCH] mailmap: resurrect lower-casing of email addresses

[PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the
lower-casing of email addresses.  This mostly did not matter if your
.mailmap has only lower-case email addresses;  However, we did not
require .mailmap to contain lowercase-only email addresses.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 lezzee how that goes
 mailmap.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/mailmap.c b/mailmap.c
index f12bb45..6be91b6 100644
--- a/mailmap.c
+++ b/mailmap.c
@@ -50,6 +50,15 @@ static void add_mapping(struct string_list *map,
 {
 	struct mailmap_entry *me;
 	int index;
+	char *p;
+
+	if (old_email)
+		for (p = old_email; *p; p++)
+			*p = tolower(*p);
+	if (new_email)
+		for (p = new_email; *p; p++)
+			*p = tolower(*p);
+
 	if (old_email == NULL) {
 		old_email = new_email;
 		new_email = NULL;
-- 
1.6.2.1.613.g25746

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

{I may be late to this change since I'm trying to catch up on the ML.]
Johannes Schindelin wrote:
> Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the
> lower-casing of email addresses.  This mostly did not matter if your
> .mailmap has only lower-case email addresses;  However, we did not
> require .mailmap to contain lowercase-only email addresses.

What part of the email address is this going to lowercase? Only the 
domain name is case agnostic.

> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  lezzee how that goes
>  mailmap.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/mailmap.c b/mailmap.c
> index f12bb45..6be91b6 100644
> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -50,6 +50,15 @@ static void add_mapping(struct string_list *map,
>  {
>  	struct mailmap_entry *me;
>  	int index;
> +	char *p;
> +
> +	if (old_email)
> +		for (p = old_email; *p; p++)
> +			*p = tolower(*p);
> +	if (new_email)
> +		for (p = new_email; *p; p++)
> +			*p = tolower(*p);
> +
>  	if (old_email == NULL) {
>  		old_email = new_email;
>  		new_email = NULL;

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Thu, 2 Apr 2009, A Large Angry SCM wrote:

> {I may be late to this change since I'm trying to catch up on the ML.]
> Johannes Schindelin wrote:
> > Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the
> > lower-casing of email addresses.  This mostly did not matter if your
> > .mailmap has only lower-case email addresses;  However, we did not
> > require .mailmap to contain lowercase-only email addresses.
> 
> What part of the email address is this going to lowercase? Only the domain
> name is case agnostic.

If that were true, I would get 10% emails less.

Ciao,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> What part of the email address is this going to lowercase? Only the domain
>> name is case agnostic.

That is my understanding of RFC, too.  Let's see where this mail goes to
find out how much more lenient the real world is ;-).

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>>> What part of the email address is this going to lowercase? Only the domain
>>> name is case agnostic.
> 
> That is my understanding of RFC, too.  Let's see where this mail goes to
> find out how much more lenient the real world is ;-).
> 
> 

Many email providers/servers are lenient when it comes to case in the 
local part of an email address (after all, they control the 
interpretation) but not every provider/server is and the RFC is VERY 
clear on this issue.

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Thu, 2 Apr 2009, A Large Angry SCM wrote:

> Junio C Hamano wrote:
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > 
> > > > What part of the email address is this going to lowercase? Only the
> > > > domain
> > > > name is case agnostic.
> > 
> > That is my understanding of RFC, too.  Let's see where this mail goes to
> > find out how much more lenient the real world is ;-).
> > 
> > 
> 
> Many email providers/servers are lenient when it comes to case in the 
> local part of an email address (after all, they control the 
> interpretation) but not every provider/server is and the RFC is VERY 
> clear on this issue.

And in one of my projects it is _very_ clear that this strict 
interpretation of the RFC, which does not matter in reality, _actively_ 
_hurts_.

In the alternative, can I ask you to adjust my .mailmap in your free time?

Thankyouverymuch,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

Johannes Schindelin wrote:
> Hi,
> 
> On Thu, 2 Apr 2009, A Large Angry SCM wrote:
> 
>> Junio C Hamano wrote:
>>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>>
>>>>> What part of the email address is this going to lowercase? Only the
>>>>> domain
>>>>> name is case agnostic.
>>> That is my understanding of RFC, too.  Let's see where this mail goes to
>>> find out how much more lenient the real world is ;-).
>>>
>>>
>> Many email providers/servers are lenient when it comes to case in the 
>> local part of an email address (after all, they control the 
>> interpretation) but not every provider/server is and the RFC is VERY 
>> clear on this issue.
> 
> And in one of my projects it is _very_ clear that this strict 
> interpretation of the RFC, which does not matter in reality, _actively_ 
> _hurts_.

Care to provide actual justification for that statement.

> In the alternative, can I ask you to adjust my .mailmap in your free time?

_Your_ .mailmap file is your issue.

So which standards do you choose to follow and which do you choose to 
ignore?

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Thu, 2 Apr 2009, A Large Angry SCM wrote:

> Johannes Schindelin wrote:
> 
> > On Thu, 2 Apr 2009, A Large Angry SCM wrote:
> > 
> > > Junio C Hamano wrote:
> > > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > > >
> > > > > > What part of the email address is this going to lowercase? 
> > > > > > Only the domain name is case agnostic.
> > > >
> > > > That is my understanding of RFC, too.  Let's see where this mail 
> > > > goes to find out how much more lenient the real world is ;-).
> > > >
> > > Many email providers/servers are lenient when it comes to case in 
> > > the local part of an email address (after all, they control the 
> > > interpretation) but not every provider/server is and the RFC is VERY 
> > > clear on this issue.
> > 
> > And in one of my projects it is _very_ clear that this strict 
> > interpretation of the RFC, which does not matter in reality, 
> > _actively_ _hurts_.
> 
> Care to provide actual justification for that statement.

Well, I _did_!  I have at least _one_ repository where the case 
insensitive email addresses worked, and got fscked over, by having Git 
change behavior behind my back!

> > In the alternative, can I ask you to adjust my .mailmap in your free 
> > time?
> 
> _Your_ .mailmap file is your issue.
> 
> So which standards do you choose to follow and which do you choose to 
> ignore?

You chose a rather inappropriate moment to start one of those damned 
flamewars -- I am in the middle of some rather important day-job meeting, 
plus two projects in the deadline-is-looming GSoC frenzy.

In case it was not clear yet: if I have to chose between following a 
standard and reality that just took over, I will _always_ choose the 
latter.

If you take this mail to start a flamewar for real (i.e. not answer to my 
concerns, but point out that standard X says bla, and that everybody else 
should just obey, oh, and fix their ways as of 20 years), please do remove 
me from the Cc: list.

Ciao,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Jeff King]

On Fri, Apr 03, 2009 at 04:52:46AM +0200, Johannes Schindelin wrote:

> In case it was not clear yet: if I have to chose between following a 
> standard and reality that just took over, I will _always_ choose the 
> latter.

The problem with "reality" here is that it is not 100% case-insensitive
(and I'm not sure we have anything resembling actual data), and worse,
that the person using git and the person whose reality is case-sensitive
are _different_ people. So you could be breaking email addresses and
have no idea, because the case-sensitivity is implemented on some random
contributor's mail server.

That being said, this is actually restoring behavior broken only about 6
weeks ago (and looks like it was broken in 1.6.2, but no other release).
So I am inclined to say this patch should be applied regardless of
standards and reality if only because it is making git's behavior
consistent across versions. And it looks like Junio has already applied
it.

Now what git _should_ do is another question. Mailmap has been
lower-casing addresses since 5496523 (shortlog: handle email addresses
case-insensitively, 2006-11-19), and I don't think we've had a single
complaint or bug report. Which implies that either reality _is_
primarily case-sensitive, or that people are not actually feeding
mailmap'd addresses to mail servers. So if there is an issue, it is
certainly not pressing, and while I can see and support a concerned
somebody making a patch to address it, I am not that somebody.

Such a patch would have to take into account the very real use case
Dscho is handling, but also address some other real use case (like
cutting and pasting from shortlog output into a MUA).  I assume the
lower-casing is primarily used for aggregating similar addresses; we can
do better to _preserve_ case while matching insensitively (and if there
are multiple cases, then we pick one arbitrarily -- presumably that
address _is_ case insensitive if it was used both ways).

Doing my best to turn a flame war into an actual discussion of merit,

-Peff

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

Johannes Schindelin wrote:
> Hi,
> 
> On Thu, 2 Apr 2009, A Large Angry SCM wrote:
> 
>> Johannes Schindelin wrote:
>>
>>> On Thu, 2 Apr 2009, A Large Angry SCM wrote:
>>>
>>>> Junio C Hamano wrote:
>>>>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>>>>
>>>>>>> What part of the email address is this going to lowercase? 
>>>>>>> Only the domain name is case agnostic.
>>>>> That is my understanding of RFC, too.  Let's see where this mail 
>>>>> goes to find out how much more lenient the real world is ;-).
>>>>>
>>>> Many email providers/servers are lenient when it comes to case in 
>>>> the local part of an email address (after all, they control the 
>>>> interpretation) but not every provider/server is and the RFC is VERY 
>>>> clear on this issue.
>>> And in one of my projects it is _very_ clear that this strict 
>>> interpretation of the RFC, which does not matter in reality, 
>>> _actively_ _hurts_.
>> Care to provide actual justification for that statement.
> 
> Well, I _did_!  I have at least _one_ repository where the case 
> insensitive email addresses worked, and got fscked over, by having Git 
> change behavior behind my back!
> 
>>> In the alternative, can I ask you to adjust my .mailmap in your free 
>>> time?
>> _Your_ .mailmap file is your issue.
>>
>> So which standards do you choose to follow and which do you choose to 
>> ignore?
> 
> You chose a rather inappropriate moment to start one of those damned 
> flamewars -- I am in the middle of some rather important day-job meeting, 
> plus two projects in the deadline-is-looming GSoC frenzy.
> 
> In case it was not clear yet: if I have to chose between following a 
> standard and reality that just took over, I will _always_ choose the 
> latter.
> 
> If you take this mail to start a flamewar for real (i.e. not answer to my 
> concerns, but point out that standard X says bla, and that everybody else 
> should just obey, oh, and fix their ways as of 20 years), please do remove 
> me from the Cc: list.
> 
> Ciao,
> Dscho
> )
> 

Sorry, this is not a flame war (and as Peff already sent a response that 
superior to my own) so I'll let Junio decide.

However, to keep the peace (and as a thank you for all the hard work to 
date, I'll say that I'm scheduled to be be Germany and Munich the first 
10 days in October and I'll buy the first $100 dollars in drinks at any 
meet that participate in (as a thank you to all the hard work for git 
that has been performed) that may happen that I participate in).

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Fri, 3 Apr 2009, A Large Angry SCM wrote:

> Sorry, this is not a flame war (and as Peff already sent a response that 
> superior to my own) so I'll let Junio decide.

Thanks for keeping a cool head where I failed.  My sincere apologies.

> However, to keep the peace (and as a thank you for all the hard work to 
> date, I'll say that I'm scheduled to be be Germany and Munich the first 
> 10 days in October and I'll buy the first $100 dollars in drinks at any 
> meet that participate in (as a thank you to all the hard work for git 
> that has been performed) that may happen that I participate in).

I'll take you up on that!

Ciao,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

Johannes Schindelin wrote:
> Hi,
> 
> On Fri, 3 Apr 2009, A Large Angry SCM wrote:
> 
>> Sorry, this is not a flame war (and as Peff already sent a response that 
>> superior to my own) so I'll let Junio decide.
> 
> Thanks for keeping a cool head where I failed.  My sincere apologies.
> 
>> However, to keep the peace (and as a thank you for all the hard work to 
>> date, I'll say that I'm scheduled to be be Germany and Munich the first 
>> 10 days in October and I'll buy the first $100 dollars in drinks at any 
>> meet that participate in (as a thank you to all the hard work for git 
>> that has been performed) that may happen that I participate in).
> 
> I'll take you up on that!

s/Germany and Munich/Berlin and Munich/

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Mon, 6 Apr 2009, A Large Angry SCM wrote:

> Johannes Schindelin wrote:
> 
> > On Fri, 3 Apr 2009, A Large Angry SCM wrote:
> > 
> > > Sorry, this is not a flame war (and as Peff already sent a response 
> > > that superior to my own) so I'll let Junio decide.
> > 
> > Thanks for keeping a cool head where I failed.  My sincere apologies.
> > 
> > > However, to keep the peace (and as a thank you for all the hard work 
> > > to date, I'll say that I'm scheduled to be be Germany and Munich the 
> > > first 10 days in October and I'll buy the first $100 dollars in 
> > > drinks at any meet that participate in (as a thank you to all the 
> > > hard work for git that has been performed) that may happen that I 
> > > participate in).
> > 
> > I'll take you up on that!
> 
> s/Germany and Munich/Berlin and Munich/

Cool!  Berlin is only 2 hours from my home, so let's meet there!

We could even use the opportunity for a little informal German 
GitTogether... "Alles wird Git!"?

Ciao,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Markus Heidelberg]

Johannes Schindelin, 07.04.2009:
> Hi,
> 
> On Mon, 6 Apr 2009, A Large Angry SCM wrote:
> 
> > s/Germany and Munich/Berlin and Munich/
> 
> Cool!  Berlin is only 2 hours from my home, so let's meet there!
> 
> We could even use the opportunity for a little informal German 
> GitTogether... "Alles wird Git!"?

Damn, why only is Berlin on the other end of Germany compared to where I
live?

Nice slogan, BTW.

Markus

Alles wird Git, was Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

[following ALASCM's example, I am culling the Cc: list]

On Tue, 7 Apr 2009, Markus Heidelberg wrote:

> Johannes Schindelin, 07.04.2009:
> 
> > On Mon, 6 Apr 2009, A Large Angry SCM wrote:
> > 
> > > s/Germany and Munich/Berlin and Munich/
> > 
> > Cool!  Berlin is only 2 hours from my home, so let's meet there!
> > 
> > We could even use the opportunity for a little informal German 
> > GitTogether... "Alles wird Git!"?
> 
> Damn, why only is Berlin on the other end of Germany compared to where I 
> live?

There are planes ;-)

> Nice slogan, BTW.

Thanks!

Ciao,
Dscho

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

[CC list trimmed since I don't Junio is that interested in what this 
thread has morphed into.]

Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 6 Apr 2009, A Large Angry SCM wrote:
> 
>> Johannes Schindelin wrote:
>>
>>> On Fri, 3 Apr 2009, A Large Angry SCM wrote:
>>>
>>>> Sorry, this is not a flame war (and as Peff already sent a response 
>>>> that superior to my own) so I'll let Junio decide.
>>> Thanks for keeping a cool head where I failed.  My sincere apologies.
>>>
>>>> However, to keep the peace (and as a thank you for all the hard work 
>>>> to date, I'll say that I'm scheduled to be be Germany and Munich the 
>>>> first 10 days in October and I'll buy the first $100 dollars in 
>>>> drinks at any meet that participate in (as a thank you to all the 
>>>> hard work for git that has been performed) that may happen that I 
>>>> participate in).
>>> I'll take you up on that!
>> s/Germany and Munich/Berlin and Munich/
> 
> Cool!  Berlin is only 2 hours from my home, so let's meet there!
> 
> We could even use the opportunity for a little informal German 
> GitTogether... "Alles wird Git!"?

Could you translate that for the Deutsch-challenged among us?

According to the /current/ itinerary, the evenings I have free in Berlin 
are Saturday Oct 3 and Monday Oct 5.

Alles wird Git, was Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Johannes Schindelin]

Hi,

On Tue, 7 Apr 2009, A Large Angry SCM wrote:

> [CC list trimmed since I don't Junio is that interested in what this thread
> has morphed into.]
> 
> Johannes Schindelin wrote:
>
> > We could even use the opportunity for a little informal German 
> > GitTogether... "Alles wird Git!"?
> 
> Could you translate that for the Deutsch-challenged among us?

No problem:

	Everything is going to be alright.

(with the "alright" part misspelt so it reads "git" ;-)

> According to the /current/ itinerary, the evenings I have free in Berlin 
> are Saturday Oct 3 and Monday Oct 5.

Sir, we have a date.

Ciao,
Dscho

Re: Alles wird Git

[A Large Angry SCM]

Johannes Schindelin wrote:
> Hi,
> 
> On Tue, 7 Apr 2009, A Large Angry SCM wrote:
> 
>> [CC list trimmed since I don't Junio is that interested in what this thread
>> has morphed into.]
>>
>> Johannes Schindelin wrote:
>>
>>> We could even use the opportunity for a little informal German 
>>> GitTogether... "Alles wird Git!"?
>> Could you translate that for the Deutsch-challenged among us?
> 
> No problem:
> 
> 	Everything is going to be alright.
> 
> (with the "alright" part misspelt so it reads "git" ;-)
> 
>> According to the /current/ itinerary, the evenings I have free in Berlin 
>> are Saturday Oct 3 and Monday Oct 5.
> 
> Sir, we have a date.

Which date?

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[A Large Angry SCM]

Johannes Schindelin wrote:
> Hi,
> 
> On Thu, 2 Apr 2009, A Large Angry SCM wrote:
> 
>> Johannes Schindelin wrote:
>>
>>> On Thu, 2 Apr 2009, A Large Angry SCM wrote:
>>>
>>>> Junio C Hamano wrote:
>>>>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>>>>
>>>>>>> What part of the email address is this going to lowercase? 
>>>>>>> Only the domain name is case agnostic.
>>>>> That is my understanding of RFC, too.  Let's see where this mail 
>>>>> goes to find out how much more lenient the real world is ;-).
>>>>>
>>>> Many email providers/servers are lenient when it comes to case in 
>>>> the local part of an email address (after all, they control the 
>>>> interpretation) but not every provider/server is and the RFC is VERY 
>>>> clear on this issue.
>>> And in one of my projects it is _very_ clear that this strict 
>>> interpretation of the RFC, which does not matter in reality, 
>>> _actively_ _hurts_.
>> Care to provide actual justification for that statement.
> 
> Well, I _did_!  I have at least _one_ repository where the case 
> insensitive email addresses worked, and got fscked over, by having Git 
> change behavior behind my back!
> 
>>> In the alternative, can I ask you to adjust my .mailmap in your free 
>>> time?
>> _Your_ .mailmap file is your issue.
>>
>> So which standards do you choose to follow and which do you choose to 
>> ignore?
> 
> You chose a rather inappropriate moment to start one of those damned 
> flamewars -- I am in the middle of some rather important day-job meeting, 
> plus two projects in the deadline-is-looming GSoC frenzy.
> 
> In case it was not clear yet: if I have to chose between following a 
> standard and reality that just took over, I will _always_ choose the 
> latter.
> 
> If you take this mail to start a flamewar for real (i.e. not answer to my 
> concerns, but point out that standard X says bla, and that everybody else 
> should just obey, oh, and fix their ways as of 20 years), please do remove 
> me from the Cc: list.

This is not worth a flame-war, and Peff has already created a response 
superior to my own, so I'll leave to Junio to find the best(TM) path.

Re: [PATCH] mailmap: resurrect lower-casing of email addresses

[Marius Storm-Olsen]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Johannes Schindelin said the following on 31.03.2009 02:18:
> Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the
> lower-casing of email addresses.  This mostly did not matter if your
> .mailmap has only lower-case email addresses;  However, we did not
> require .mailmap to contain lowercase-only email addresses.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Ouch! Sorry for missing that part! IMO, it would be correct to simply 
restore previous behavior to lowercase the whole email, so:

Ack-by: Marius Storm-Olsen <marius@trolltech.com>

-- 
.marius [@trolltech.com]
'if you know what you're doing, it's not research'


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 187 bytes --]