From: Paolo Bonzini <bonzini@gnu.org>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/3] rev-list: remove last static vars used in "show_commit"
Date: Wed, 08 Apr 2009 09:40:12 +0200 [thread overview]
Message-ID: <49DC54DC.3060408@gnu.org> (raw)
In-Reply-To: <20090407040854.4338.40055.chriscool@tuxfamily.org>
> struct rev_info revs;
> + struct rev_list_info info;
> int reaches = 0, all = 0;
>
> + memset(&info, 0, sizeof(info));
> + info.revs = &revs;
Would it make sense to embed the struct rev_info entirely in the new
struct, without going through a pointer?
Paolo
next prev parent reply other threads:[~2009-04-08 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090407040819.4338.4291.chriscool@tuxfamily.org>
2009-04-06 19:28 ` [PATCH 1/3] list-objects: add "void *data" parameter to show functions Christian Couder
2009-04-06 20:28 ` [PATCH 2/3] rev-list: remove last static vars used in "show_commit" Christian Couder
2009-04-07 3:08 ` [PATCH 3/3] rev-list: add "int bisect_show_flags" in "struct rev_list_info" Christian Couder
2009-04-08 7:40 ` Paolo Bonzini [this message]
2009-04-09 3:11 ` [PATCH 2/3] rev-list: remove last static vars used in "show_commit" Christian Couder
2009-04-08 2:29 ` [PATCH 1/3] list-objects: add "void *data" parameter to show functions Junio C Hamano
2009-04-08 4:39 ` Christian Couder
2009-04-08 5:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DC54DC.3060408@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).