From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Thomas Jarosch <thomas.jarosch@intra2net.com>,
git@vger.kernel.org, markus.heidelberg@web.de
Subject: Re: [PATCH v2] Fix buffer overflow in config parser
Date: Wed, 15 Apr 2009 09:39:36 +0200 [thread overview]
Message-ID: <49E58F38.5060103@viscovery.net> (raw)
In-Reply-To: <49E5888D.2090607@viscovery.net>
Johannes Sixt schrieb:
> Junio C Hamano schrieb:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>> Hi,
>>>
>>> On Tue, 14 Apr 2009, Thomas Jarosch wrote:
>>>
>>>> t/t1303-wacky-config.sh | 9 ++++++++-
>>> I like the name!
>>>
>>>> +LONG_VALUE=`perl -e 'print "x" x 1023," a"'`
>>> But should it not be guarded against NO_PERL?
>> The right question to ask is a rhetorical "do we need perl to do this?"
>
> LONG_VALUE=$(printf "x%0.1021dx a", 7)
Oops! Make this
LONG_VALUE=$(printf "x%01021dx a" 7)
-- Hannes
next prev parent reply other threads:[~2009-04-15 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 21:28 [PATCH v2] Fix buffer overflow in config parser Thomas Jarosch
2009-04-14 21:41 ` Johannes Schindelin
2009-04-14 21:47 ` Thomas Jarosch
2009-04-15 7:50 ` Jeff King
2009-04-15 7:53 ` Jeff King
2009-04-14 22:38 ` Junio C Hamano
2009-04-15 7:11 ` Johannes Sixt
2009-04-15 7:39 ` Johannes Sixt [this message]
2009-04-17 12:05 ` [PATCH v3] " Thomas Jarosch
2009-04-17 13:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E58F38.5060103@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).