From: Paolo Bonzini <bonzini@gnu.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Christian Couder <chriscool@tuxfamily.org>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] rev-list: embed "struct rev_info revs" into "struct rev_list_info"
Date: Sat, 18 Apr 2009 12:56:04 +0200 [thread overview]
Message-ID: <49E9B1C4.50100@gnu.org> (raw)
In-Reply-To: <20090418191125.6117@nanako3.lavabit.com>
Nanako Shiraishi wrote:
> Quoting Christian Couder <chriscool@tuxfamily.org>:
>
>> There are downsides to this patch. First it is big. And "revs" is
>> initialized once when doing "memset(&info, 0, sizeof(info))" and
>> once in "init_revisions".
>
> I'm sorry if it is obvious, but is there any upsides?
As the patch shows, the lifetime of the revs is the same as that of info
(i.e., there are never memcpys from something into revs).
Paolo
prev parent reply other threads:[~2009-04-18 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 4:43 [RFC/PATCH] rev-list: embed "struct rev_info revs" into "struct rev_list_info" Christian Couder
2009-04-18 10:11 ` Nanako Shiraishi
2009-04-18 10:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E9B1C4.50100@gnu.org \
--to=bonzini@gnu.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).