From: Stephen Boyd <bebarino@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Andreas Ericsson <exon@op5.com>
Subject: Re: [PATCH 1/8] config.txt: remove pointer to SubmittingPatches
Date: Thu, 23 Apr 2009 09:03:41 -0700 [thread overview]
Message-ID: <49F0915D.9030009@gmail.com> (raw)
In-Reply-To: <49F05978.30009@drmicha.warpmail.net>
Michael J Gruber wrote:
> Stephen Boyd venit, vidit, dixit 23.04.2009 11:37:
>> SubmittingPatches exists in the git source documentation for developers
>> of git and is not included in the man/html page distributions.
>>
>> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
>> ---
>> Documentation/config.txt | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> index 35056e1..fb7adfa 100644
>> --- a/Documentation/config.txt
>> +++ b/Documentation/config.txt
>> @@ -743,7 +743,6 @@ format.signoff::
>> format-patch by default. *Note:* Adding the Signed-off-by: line to a
>> patch should be a conscious act and means that you certify you have
>> the rights to submit this work under the same open source license.
>> - Please see the 'SubmittingPatches' document for further discussion.
>
> Shouldn't we point to the source then? We're not talking about links
> here, only references in the sense of referring to further reading.
I was thinking that a user isn't going to download the source for git so
they can read the SubmittingPatches document. Although, it's possible
they downloaded the tarball and built from source so they would have the
file.
Now I'm starting to dislike this whole paragraph because git isn't used
exclusively for open source software. Seems like others agree with a
little searching of gmane[1]
I think Andreas Ericsson's version with Jeff King's updates would be good.
Junio, I would say drop this patch.
[1] http://thread.gmane.org/gmane.comp.version-control.git/115299
prev parent reply other threads:[~2009-04-23 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 9:37 [PATCH 0/8] Doc updates to config, format-patch, show-branch Stephen Boyd
2009-04-23 9:37 ` [PATCH 1/8] config.txt: remove pointer to SubmittingPatches Stephen Boyd
2009-04-23 9:37 ` [PATCH 2/8] config.txt: add missing format.{subjectprefix,cc,attach} variables Stephen Boyd
2009-04-23 9:37 ` [PATCH 3/8] Documentation: use lowercase for shallow and deep threading Stephen Boyd
2009-04-23 9:37 ` [PATCH 4/8] git-show-branch.txt: cleanup example description Stephen Boyd
2009-04-23 9:37 ` [PATCH 5/8] git-format-patch.txt: general rewordings and cleanups Stephen Boyd
2009-04-23 9:38 ` [PATCH 6/8] config.txt: add missing 'the's and make words plural Stephen Boyd
2009-04-23 9:38 ` [PATCH 7/8] config.txt: clarify sentences in the configuration and syntax sections Stephen Boyd
2009-04-23 9:38 ` [PATCH 8/8] config.txt: Make configuration paragraph more consistent Stephen Boyd
2009-04-23 12:14 ` [PATCH 5/8] git-format-patch.txt: general rewordings and cleanups Michael J Gruber
2009-04-23 16:16 ` [PATCHv2 " Stephen Boyd
2009-04-24 16:18 ` Junio C Hamano
2009-04-23 12:05 ` [PATCH 1/8] config.txt: remove pointer to SubmittingPatches Michael J Gruber
2009-04-23 16:03 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F0915D.9030009@gmail.com \
--to=bebarino@gmail.com \
--cc=exon@op5.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).