From: Stephen Boyd <bebarino@gmail.com>
To: "Wesley J. Landaker" <wjl@icecavern.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Documentation: git-clean: make description more readable
Date: Sun, 26 Apr 2009 01:04:16 -0700 [thread overview]
Message-ID: <49F41580.3080004@gmail.com> (raw)
In-Reply-To: <200904251923.46448.wjl@icecavern.net>
Wesley J. Landaker wrote:
> The main reason I took that out in my patch was because I think the second
> sentence more says the same thing, except more clearly, and the exact
> semantics of "files unknown to git" versus "ignored files", etc seem to not have
> good definitions anyway, so I left that for the second paragraph that talks
> about how '-x' changes things.
If you want to keep it, maybe change it to be more active. Something like:
Cleans the working tree by removing files that are not under version
control.
> So I might edit yours to say:
>
> Specifying the '-x' option will also remove ignored files. This is useful to
> remove, for example, generated files that are normally ignored.
The "for example" just comes sticking out again. Could you put it at the
beginning of the sentence?
> I left the part about '-x' there mostly because it was already in there, so I
> figured someone at some point thought it was special enough. I didn't want to
> undo any good decisions that had already been made. =) That said, both -x and
> -X are somewhat special because they change the behavior a LOT compared to,
> say, -d.
So maybe -X should be described as well?
next prev parent reply other threads:[~2009-04-26 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 15:13 [PATCH 0/2] Documentation: git-clean: description updates Wesley J. Landaker
2009-04-25 15:13 ` [PATCH 1/2] Documentation: git-clean: fix minor grammatical errors Wesley J. Landaker
2009-04-25 15:13 ` [PATCH 2/2] Documentation: git-clean: make description more readable Wesley J. Landaker
2009-04-25 18:36 ` Stephen Boyd
2009-04-26 1:23 ` Wesley J. Landaker
2009-04-26 8:04 ` Stephen Boyd [this message]
2009-04-26 0:10 ` [PATCH 0/2] Documentation: git-clean: description updates Junio C Hamano
2009-04-26 1:33 ` Wesley J. Landaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F41580.3080004@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wjl@icecavern.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).