From: Michael J Gruber <git@drmicha.warpmail.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2] Add --reference option to git submodule.
Date: Tue, 28 Apr 2009 19:01:54 +0200 [thread overview]
Message-ID: <49F73682.2010404@drmicha.warpmail.net> (raw)
In-Reply-To: <49F717D4.70708@viscovery.net>
Johannes Sixt venit, vidit, dixit 28.04.2009 16:51:
> Michael J Gruber schrieb:
>> BTW, even dash has "test STRING" so portability doesn't require -n but I
>> think it's OK either way.
>
> It is not if STRING is user input; it could be, e.g., '-f', and then the
> command gives a syntax error because of a missing argument.
>
> It's safer to use test -z and test -n unless the string to test is
> completely under the control of the script.
Yep, that's true as a general rule. Here it's always preceeded by
"--reference=". But in any case I'm happy I suggested -n and it's in ;)
Michael
next prev parent reply other threads:[~2009-04-28 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 12:30 [PATCHv2] Add --reference option to git submodule Michael S. Tsirkin
2009-04-28 13:21 ` Michael J Gruber
2009-04-28 14:51 ` Johannes Sixt
2009-04-28 17:01 ` Michael J Gruber [this message]
2009-04-28 18:52 ` Junio C Hamano
2009-05-04 17:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F73682.2010404@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).