git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: elupus <elupus@ecce.se>
Cc: git@vger.kernel.org
Subject: Re: git 1.5.4.3 push incorrectly honors grafts file
Date: Mon, 04 May 2009 19:25:27 +0200	[thread overview]
Message-ID: <49FF2507.6070602@kdbg.org> (raw)
In-Reply-To: <atsddmx5kuva.1fyy780hhh9t2$.dlg@40tude.net>

elupus schrieb:
> On Mon, 27 Apr 2009 17:51:05 +0200, elupus wrote:
> 
>> Hi, 
>>
>> I recently had a problem with git push honoring the grafts file. It caused
>> it not to push all data required for a branch to the remote repository,
>> rendering it impossible to clone the remote repository (missing blobs)
>>
>> This was with an not so fresh git version of 1.5.4.3 (ubuntu hardy).
>>
>> Has this issue been fixed in later git version? I saw a thread talking
>> about it a long time ago (long before my release in question) on this
>> mailing list, but nothing was mentioned about if it was actually solved.
>>
>> Regards
>> Joakim Plate
> 
> Bump, anybody know of a way to avoid this? The problem even occurs on the
> local machine in that git gc will cleanup stuff that isn't required due to
> the grafts file, rendering the repo invalid if the graft file is removed.
> 
> I don't think running filter-branch on the git svn imported branches seems
> like a good idea. since that would also wreak havoc on any repo that pulls
> from mine (ie still private repo like usb stick or other dev machine). 
> 
> Imho, grafts shouldn't be honored on either push/pull/gc operations. 

Right.

It's a know issue. But it was nobody's itch, yet, perhaps because too few 
people use grafts. There is a topic, cc/replace, in Junio's pu branch that 
introduces "replacement objects"; these are a generalization of grafts. If 
effort is invested, then it's best to nurse this topic.

-- Hannes

  reply	other threads:[~2009-05-04 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 15:51 git 1.5.4.3 push incorrectly honors grafts file elupus
2009-05-03 17:14 ` elupus
2009-05-04 17:25   ` Johannes Sixt [this message]
2009-05-04 17:54     ` elupus
2009-05-04 20:40   ` Dmitry Potapov
2009-05-05  1:00     ` elupus
2009-05-04 12:33 ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FF2507.6070602@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=elupus@ecce.se \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).