From: Johannes Sixt <j.sixt@viscovery.net>
To: Matthias Andree <matthias.andree@gmx.de>
Cc: git@vger.kernel.org, "Junio C. Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] To make GIT-VERSION-FILE, search for git more widely
Date: Thu, 07 May 2009 10:35:15 +0200 [thread overview]
Message-ID: <4A029D43.4030604@viscovery.net> (raw)
In-Reply-To: <1241684666-18956-1-git-send-email-matthias.andree@gmx.de>
(sorry for the previous message; fingers were too fast)
Matthias Andree schrieb:
> + VN=$(${GIT} describe --abbrev=4 HEAD 2>/dev/null) &&
> + ${GIT} update-index -q --refresh
> + test -z "$(${GIT} diff-index --name-only HEAD --)" ||
Use "$GIT" in all those cases
> GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
> - @$(SHELL_PATH) ./GIT-VERSION-GEN
> + @{ GIT=./git$X ; type $$GIT >/dev/null 2>&1 ; } \
+ @{ GIT=./git$X ; type "$$GIT" >/dev/null 2>&1 ; } \
> + || { GIT=$(prefix)/bin/git$X ; type $$GIT >/dev/null 2>&1 ; }\
+ || { GIT='$(prefix_SQ)/bin/git$X' ; type "$$GIT" >/dev/null 2>&1 ; }\
BTW, isn't `test -x "$GIT"` better in some way than `type "$GIT"`?
> + || GIT=git ; \
> + export GIT ; \
> + $(SHELL_PATH) ./GIT-VERSION-GEN
-- Hannes
next prev parent reply other threads:[~2009-05-07 8:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:24 [PATCH] To make GIT-VERSION-FILE, search for git more widely Matthias Andree
2009-05-07 8:28 ` Johannes Sixt
2009-05-07 8:33 ` Junio C Hamano
2009-05-07 8:40 ` Matthias Andree
2009-05-07 8:54 ` [PATCH] " Nicolas Sebrecht
2009-05-07 8:56 ` Matthias Andree
2009-05-07 9:02 ` Nicolas Sebrecht
2009-05-07 8:47 ` [PATCH] " Johannes Sixt
2009-05-07 9:02 ` Michael J Gruber
2009-05-07 9:13 ` Matthias Andree
2009-05-07 9:02 ` Matthias Andree
2009-05-07 8:35 ` Johannes Sixt [this message]
2009-05-07 8:58 ` [PATCH v2] " Matthias Andree
-- strict thread matches above, loose matches on Subject: below --
2009-04-26 11:59 [PATCH] " Matthias Andree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A029D43.4030604@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthias.andree@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).