git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthias Andree <matthias.andree@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] To make GIT-VERSION-FILE, search for git more widely
Date: Thu, 07 May 2009 10:47:04 +0200	[thread overview]
Message-ID: <4A02A008.30800@viscovery.net> (raw)
In-Reply-To: <7vws8te2ht.fsf@alter.siamese.dyndns.org>

Junio C Hamano schrieb:
> Matthias Andree <matthias.andree@gmx.de> writes:
> 
>> Problem: when git is installed into /usr/local/bin, running 'sudo make
>> install' won't find git in $PATH (because sudo strips PATH, for instance
>> on openSUSE 11.1, and doesn't include /usr/local/whatever).
> 
> That sounds like a bug/misfeature in sudo (which I do not use) to me.

sudo resets the environment, in particular also PATH. Why would this be a bug?

Current distros set env_reset in /etc/soduers for a reason. Not that I
know the reason in detail, but I won't claim that I'm more clever with
regards to security issues than distro packagers; so I trust that if they
do it, then it makes sense.

-- Hannes

  parent reply	other threads:[~2009-05-07  8:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07  8:24 [PATCH] To make GIT-VERSION-FILE, search for git more widely Matthias Andree
2009-05-07  8:28 ` Johannes Sixt
2009-05-07  8:33 ` Junio C Hamano
2009-05-07  8:40   ` Matthias Andree
2009-05-07  8:54     ` [PATCH] " Nicolas Sebrecht
2009-05-07  8:56       ` Matthias Andree
2009-05-07  9:02         ` Nicolas Sebrecht
2009-05-07  8:47   ` Johannes Sixt [this message]
2009-05-07  9:02     ` [PATCH] " Michael J Gruber
2009-05-07  9:13       ` Matthias Andree
2009-05-07  9:02     ` Matthias Andree
2009-05-07  8:35 ` Johannes Sixt
2009-05-07  8:58   ` [PATCH v2] " Matthias Andree
  -- strict thread matches above, loose matches on Subject: below --
2009-04-26 11:59 [PATCH] " Matthias Andree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A02A008.30800@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=matthias.andree@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).