From: Johannes Sixt <j.sixt@viscovery.net>
To: Paul Mackerras <paulus@samba.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] gitk: use --textconv to generate diff text
Date: Mon, 11 May 2009 09:34:50 +0200 [thread overview]
Message-ID: <4A07D51A.4090409@viscovery.net> (raw)
In-Reply-To: <4A07D160.9020709@viscovery.net>
Johannes Sixt schrieb:
> From: Johannes Sixt <j6t@kdbg.org>
> Date: Tue, 28 Apr 2009 14:03:54 +0200
>
> For the most part gitk's focus is on showing history and changes in
> a human readable form. For this reason, it makes sense to generate
> the patch text in the diff view using --textconv so that textconv drivers
> are used if they are defined.
FWIW, I keep a few Word documents in git and use catdoc as textconv
driver. This works pretty well. Git-gui doesn't show any textual changes
(it treats the Word files as binary, and it has to), with this patch I can
use gitk to preview the changes in the worktree and the index.
-- Hannes
next prev parent reply other threads:[~2009-05-11 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 7:18 [PATCH] gitk: use --textconv to generate diff text Johannes Sixt
2009-05-11 7:34 ` Johannes Sixt [this message]
2009-05-11 9:13 ` Jeff King
2009-05-11 21:20 ` Junio C Hamano
2009-05-11 21:59 ` Paul Mackerras
2009-05-11 22:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A07D51A.4090409@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).