From: Stephen Boyd <bebarino@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all
Date: Mon, 11 May 2009 22:20:26 -0700 [thread overview]
Message-ID: <4A09071A.1030107@gmail.com> (raw)
In-Reply-To: <20090509034438.GZ30527@spearce.org>
Shawn O. Pearce wrote:
> These probably could have been one patch, since the function
> is introduced only to support this one usage, and this patch
> is only 4 lines larger than the function definition anyway...
Seeing that this hasn't been picked up yet, I'm fine with this being
squashed into one commit. Could you use this combination of the two
messages for the commit?
---8<----
Subject: completion: complete config variables for
--get/getall/unset/unset-all
This should make it easier for users to get and unset their
configuration variables without having to open documentation or dig
through their configuration file.
__git_config_get_set_variables() retrieves the set configuration variables
from the appropriate configuration file. For example, if the user has
previously specified --global only the global variables are returned. The
same applies for --system, and --file. If no location has been
specified, all
set variables are returned.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
next prev parent reply other threads:[~2009-05-12 5:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 1:23 [PATCHv2 0/2] completion: config --unset/get Stephen Boyd
2009-05-09 1:23 ` [PATCHv2 1/2] completion: add __git_config_get_set_variables() to get config variables Stephen Boyd
2009-05-09 1:23 ` [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all Stephen Boyd
2009-05-09 3:44 ` Shawn O. Pearce
2009-05-12 5:20 ` Stephen Boyd [this message]
2009-05-12 8:12 ` Junio C Hamano
2009-05-12 19:05 ` Stephen Boyd
2009-05-13 18:33 ` Junio C Hamano
2009-05-13 18:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A09071A.1030107@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).