git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: git@drmicha.warpmail.net
To: Johan Herland <johan@herland.net>
Cc: gitster@pobox.com, git@vger.kernel.org,
	johannes.schindelin@gmx.de, trast@student.ethz.ch,
	tavestbo@trolltech.com, chriscool@tuxfamily.org
Subject: Re: [PATCH 0/5] RESEND: git notes
Date: Sat, 16 May 2009 17:06:55 +0200	[thread overview]
Message-ID: <4A0ED68F.6060200@drmicha.warpmail.net> (raw)
In-Reply-To: <cover.1242437696.git.johan@herland.net>

Johan Herland venit, vidit, dixit 16.05.2009 03:45:
> Hi,
> 
> Dscho has asked me to take over the responsibility for the js/notes
> patch series.
> 
> The following is a re-roll and resend of the patch series currently
> in pu, plus my own 2 patches for adding support for "-m" and "-F" to
> "git notes edit".
> 
> On advice from Dscho, I have squashed the current bugfix and cleanup
> patches in js/notes into the first 4 "main" patches. As a result the
> original 15 + 2 patch series is now down to 5 (4 + 1) patches.
> 
> In sum, these 5 patches produce the exact same result as the original
> js/notes series (plus my 2 patches).
> 
> I have taken the liberty of squashing the various Signed-off-by tags
> (along with their corresponding patches) into these 5 new patches.
> I hope this is OK with everybody. If not, I apologize; please tell me,
> and I will re-send.

Well, effectively you removed me (and others) from the author list :|

I think the issue with the tree difference after this series (compared
to the original one) shows that this squashing action makes reviewers'
lives more complicated rather than easier. If it were the other way
round squashing would be fine, of course.

Michael

> 
> 
> Have fun! :)
> 
> ...Johan
> 
> 
> Johan Herland (1):
>   Teach "-m <msg>" and "-F <file>" to "git notes edit"
> 
> Johannes Schindelin (4):
>   Introduce commit notes
>   Add a script to edit/inspect notes
>   Speed up git notes lookup
>   Add an expensive test for git-notes
> 
>  .gitignore                       |    1 +
>  Documentation/config.txt         |   13 +++
>  Documentation/git-notes.txt      |   60 ++++++++++++++
>  Makefile                         |    3 +
>  cache.h                          |    4 +
>  command-list.txt                 |    1 +
>  commit.c                         |    1 +
>  config.c                         |    5 +
>  environment.c                    |    1 +
>  git-notes.sh                     |  121 ++++++++++++++++++++++++++++
>  notes.c                          |  160 ++++++++++++++++++++++++++++++++++++++
>  notes.h                          |    7 ++
>  pretty.c                         |    5 +
>  t/t3301-notes.sh                 |  149 +++++++++++++++++++++++++++++++++++
>  t/t3302-notes-index-expensive.sh |   98 +++++++++++++++++++++++
>  15 files changed, 629 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/git-notes.txt
>  create mode 100755 git-notes.sh
>  create mode 100644 notes.c
>  create mode 100644 notes.h
>  create mode 100755 t/t3301-notes.sh
>  create mode 100755 t/t3302-notes-index-expensive.sh
> 

  parent reply	other threads:[~2009-05-16 15:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  1:45 [PATCH 0/5] RESEND: git notes Johan Herland
2009-05-16  1:45 ` [PATCH 1/5] Introduce commit notes Johan Herland
2009-05-16  1:45 ` [PATCH 2/5] Add a script to edit/inspect notes Johan Herland
2009-05-16  1:45 ` [PATCH 3/5] Speed up git notes lookup Johan Herland
2009-05-16  1:45 ` [PATCH 4/5] Add an expensive test for git-notes Johan Herland
2009-05-16  1:45 ` [PATCH 5/5] Teach "-m <msg>" and "-F <file>" to "git notes edit" Johan Herland
2009-05-16  7:06 ` [PATCH 0/5] RESEND: git notes Junio C Hamano
2009-05-16 11:20   ` Johan Herland
2009-05-16 11:44     ` [PATCHv2 " Johan Herland
2009-05-16 11:44       ` [PATCHv2 1/5] Introduce commit notes Johan Herland
2009-05-16 11:44       ` [PATCHv2 2/5] Add a script to edit/inspect notes Johan Herland
2009-05-16 11:44       ` [PATCHv2 3/5] Speed up git notes lookup Johan Herland
2009-05-16 11:44       ` [PATCHv2 4/5] Add an expensive test for git-notes Johan Herland
2009-05-16 11:44       ` [PATCHv2 5/5] Teach "-m <msg>" and "-F <file>" to "git notes edit" Johan Herland
2009-05-20 10:25       ` [PATCHv2 0/5] RESEND: git notes Johannes Schindelin
2009-05-20 11:54         ` Johan Herland
2009-05-16 15:06 ` git [this message]
2009-05-16 16:01   ` [PATCH " Johan Herland
2009-05-17 16:31   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0ED68F.6060200@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johan@herland.net \
    --cc=johannes.schindelin@gmx.de \
    --cc=tavestbo@trolltech.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).