From: Stephen Boyd <bebarino@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's
Date: Mon, 18 May 2009 01:06:23 -0700 [thread overview]
Message-ID: <4A1116FF.8030008@gmail.com> (raw)
In-Reply-To: <7vmy9aetc8.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> You are asking a wrong person. I am terrible at naming things; think
> "rerere" ;-).
>
> But I think custom-arghelp is much better than multargs. You are asking
> "use this help for argument value _literally_", so another possibility
> perhaps is PARSE_OPT_ARGHELP_LITERAL.
>
> After all, there probably are many other valid reasons why you may not
> want "s/.*/<&>/" blindly applied to your string. One reason may be
> because the string describes multiple arguments, but I suspect that it is
> not the only one. It is better to name the option after what it does,
> than naming it after one sample reason why you might want to use that
> option.
Ok. I think PARSE_OPT_LITERAL_ARGH might be good; until someone comes up
with a better one of course.
next prev parent reply other threads:[~2009-05-18 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-17 10:47 [PATCH 1/3] show-branch: Fix die message in parse_reflog_param() Stephen Boyd
2009-05-17 10:47 ` [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's Stephen Boyd
2009-05-17 10:47 ` [PATCH 3/3] show-branch: migrate to parse-options API Stephen Boyd
2009-05-18 6:14 ` [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's Junio C Hamano
2009-05-18 7:08 ` Stephen Boyd
2009-05-18 7:57 ` Junio C Hamano
2009-05-18 8:06 ` Stephen Boyd [this message]
2009-05-18 22:52 ` Jakub Narebski
2009-05-19 5:09 ` Sverre Rabbelier
2009-05-21 7:33 ` [PATCHv2 1/2] parse-options: add PARSE_OPT_LITERAL_ARGHELP " Stephen Boyd
2009-05-21 16:26 ` Junio C Hamano
2009-05-21 16:51 ` René Scharfe
2009-05-21 19:03 ` Stephen Boyd
2009-05-21 21:27 ` Stephen Boyd
2009-05-21 7:33 ` [PATCHv2 2/2] show-branch: migrate to parse-options API Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1116FF.8030008@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).