From: Johannes Sixt <j.sixt@viscovery.net>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Jakub Narebski <jnareb@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Martin Langhoff <martin.langhoff@gmail.com>,
Dmitry Potapov <dpotapov@gmail.com>,
Esko Luontola <esko.luontola@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Extend sample pre-commit hook to check for non ascii filenames
Date: Mon, 18 May 2009 14:04:08 +0200 [thread overview]
Message-ID: <4A114EB8.60609@viscovery.net> (raw)
In-Reply-To: <20090518115002.GA3374@heiko-voigts-macbook.local>
Heiko Voigt schrieb:
> Are there any problems with '\0' and tr other than swallowing of it.
I can't tell. But the commits ae90e16..aab0abf are interesting to study in
w.r.t. portability.
> In
> case not I would just change
>
> tr "\0" "\n"
> to
> tr -d '\0'
In which case I'd suggest that you call tr only once, in isascii():
tr -d '[ -~]\0'
-- Hannes
next prev parent reply other threads:[~2009-05-18 12:04 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 15:06 Cross-Platform Version Control Esko Luontola
2009-05-12 15:14 ` Shawn O. Pearce
2009-05-12 16:13 ` Johannes Schindelin
2009-05-12 17:56 ` Esko Luontola
2009-05-12 20:38 ` Johannes Schindelin
2009-05-12 21:16 ` Esko Luontola
2009-05-13 0:23 ` Johannes Schindelin
2009-05-13 5:34 ` Esko Luontola
2009-05-13 6:49 ` Alex Riesen
2009-05-13 10:15 ` Johannes Schindelin
[not found] ` <43d8ce650905130340q596043d5g45b342b62fe20e8d@mail.gmail.com>
2009-05-13 10:41 ` John Tapsell
2009-05-13 13:42 ` Jay Soffian
2009-05-13 13:44 ` Alex Riesen
2009-05-13 13:50 ` Jay Soffian
2009-05-13 13:57 ` John Tapsell
2009-05-13 15:27 ` Nicolas Pitre
2009-05-13 16:22 ` Johannes Schindelin
2009-05-13 17:24 ` Andreas Ericsson
2009-05-14 1:49 ` Miles Bader
2009-05-12 16:16 ` Jeff King
2009-05-12 16:57 ` Johannes Schindelin
2009-05-13 16:26 ` Linus Torvalds
2009-05-13 17:12 ` Linus Torvalds
2009-05-13 17:31 ` Andreas Ericsson
2009-05-13 17:46 ` Linus Torvalds
2009-05-13 18:26 ` Martin Langhoff
2009-05-13 18:37 ` Linus Torvalds
2009-05-13 21:04 ` Theodore Tso
2009-05-13 21:20 ` Linus Torvalds
2009-05-13 21:08 ` Daniel Barkalow
2009-05-13 21:29 ` Linus Torvalds
2009-05-13 20:57 ` Matthias Andree
2009-05-13 21:10 ` Linus Torvalds
2009-05-13 21:30 ` Jay Soffian
2009-05-13 21:47 ` Matthias Andree
2009-05-12 18:28 ` Dmitry Potapov
2009-05-12 18:40 ` Martin Langhoff
2009-05-12 18:55 ` Jakub Narebski
2009-05-12 21:43 ` [PATCH] Extend sample pre-commit hook to check for non ascii file/usernames Heiko Voigt
2009-05-12 21:55 ` Jakub Narebski
2009-05-14 17:59 ` [PATCH v2] Extend sample pre-commit hook to check for non ascii filenames Heiko Voigt
2009-05-15 10:52 ` Martin Langhoff
2009-05-18 9:37 ` Heiko Voigt
2009-05-18 22:26 ` Jakub Narebski
2009-06-20 12:14 ` [RFC PATCH] check for filenames that only differ in case to sample pre-commit hook Heiko Voigt
2009-05-15 14:57 ` [PATCH v2] Extend sample pre-commit hook to check for non ascii filenames Jakub Narebski
2009-05-18 9:50 ` [PATCH] " Heiko Voigt
2009-05-18 10:40 ` Johannes Sixt
2009-05-18 11:50 ` Heiko Voigt
2009-05-18 12:04 ` Johannes Sixt [this message]
2009-05-19 20:01 ` [PATCH v4] " Heiko Voigt
2009-05-18 14:42 ` [PATCH] " Junio C Hamano
2009-05-18 20:35 ` Julian Phillips
2009-05-15 18:11 ` [PATCH v2] " Junio C Hamano
2009-05-14 13:48 ` Cross-Platform Version Control Peter Krefting
2009-05-14 19:58 ` Esko Luontola
2009-05-14 20:21 ` Andreas Ericsson
2009-05-14 22:25 ` Johannes Schindelin
2009-05-15 11:18 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A114EB8.60609@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=dpotapov@gmail.com \
--cc=esko.luontola@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jnareb@gmail.com \
--cc=martin.langhoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).