From: Michael J Gruber <git@drmicha.warpmail.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons
Date: Tue, 19 May 2009 10:51:18 +0200 [thread overview]
Message-ID: <4A127306.6040904@drmicha.warpmail.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0905191043320.26154@pacific.mpi-cbg.de>
Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43:
> Hi,
>
> On Mon, 18 May 2009, Pat Thoyts wrote:
>
>>
>> msysGit generates version strings with text appended which cannot
>> be used with vcompare. Limit git_version to the first three digits
>> which are the real git version.
>>
>> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>
> Is that indent intentional?
>
> Ciao,
> Dscho
It is clearly indentional :)
[During my git beginnings, the standard output format of git log made me
believe I should format commit message bodies like that, too.]
Michael
next prev parent reply other threads:[~2009-05-19 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 21:46 [PATCH] gitk: Handle msysGit version during version comparisons Pat Thoyts
2009-05-18 22:57 ` Paul Mackerras
2009-05-19 8:43 ` Johannes Schindelin
2009-05-19 8:51 ` Michael J Gruber [this message]
2009-05-19 10:38 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A127306.6040904@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).