From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org
Subject: Re: [PATCH] setup_revisions(): do not access outside argv
Date: Thu, 21 May 2009 20:02:08 +0200 [thread overview]
Message-ID: <4A159720.3020103@intra2net.com> (raw)
In-Reply-To: <20090521041812.GE8091@sigill.intra.peff.net>
Jeff King wrote:
> Having just fixed a segfault in the GIT_TRACE code caused by a
> non-terminated argv generated by the alias code, I think I would prefer
> that we just consistently do the NULL-termination. You are otherwise
> creating a maintenance pitfall when somebody later passes the value to
> unsuspecting code.
Speaking of that, there is also one piece of code in diff.c that doesn't do
NULL-termination after a readlink() call (which never NULL-terminates).
The current use is 100% fine, though the same maintenance
argument might apply here, too. Wondering why the buffer
is allocated as PATH_MAX +1. Hmm.
Thomas
next prev parent reply other threads:[~2009-05-21 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 8:08 [PATCH] setup_revisions(): do not access outside argv Nguyễn Thái Ngọc Duy
2009-05-20 8:15 ` Johannes Sixt
2009-05-20 8:23 ` Nguyen Thai Ngoc Duy
2009-05-21 1:58 ` Junio C Hamano
2009-05-21 2:38 ` Miles Bader
2009-05-21 2:41 ` Nguyen Thai Ngoc Duy
2009-05-21 4:18 ` Jeff King
2009-05-21 18:02 ` Thomas Jarosch [this message]
2009-05-22 7:56 ` Jeff King
2009-05-22 8:02 ` Jeff King
2009-05-22 14:23 ` Thomas Jarosch
2009-05-22 15:33 ` Brandon Casey
2009-05-22 15:34 ` Jeff King
2009-05-25 10:46 ` [PATCH] convert bare readlink to strbuf_readlink Jeff King
2009-05-25 22:23 ` Junio C Hamano
[not found] ` <20090602195605.6117@nanako3.lavabit.com>
2009-06-02 13:57 ` [PATCH] setup_revisions(): do not access outside argv Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A159720.3020103@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).