From: Johannes Sixt <j.sixt@viscovery.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] commit: add function to unparse a commit and its parents
Date: Mon, 25 May 2009 11:17:18 +0200 [thread overview]
Message-ID: <4A1A621E.10703@viscovery.net> (raw)
In-Reply-To: <20090517153647.6403.44036.chriscool@tuxfamily.org>
Christian Couder schrieb:
> +static void unparse_commit_list(struct commit_list *list)
> +{
> + for (; list; list = list->next)
> + unparse_commit(list->item);
> +}
> +
> +void unparse_commit(struct commit *item)
> +{
> + item->object.flags = 0;
> + item->object.used = 0;
> + if (item->object.parsed) {
> + item->object.parsed = 0;
> + if (item->parents) {
> + unparse_commit_list(item->parents);
> + free_commit_list(item->parents);
> + item->parents = NULL;
> + }
> + }
> +}
I see a recursion here. Could this not overflow the stack if there is a
long ancestry chain?
-- Hannes
next prev parent reply other threads:[~2009-05-25 9:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090517153307.6403.73576.>
2009-05-17 15:36 ` [PATCH 1/3] bisect: rework some rev related functions to make them more reusable Christian Couder
2009-05-17 15:36 ` [PATCH 2/3] commit: add function to unparse a commit and its parents Christian Couder
2009-05-18 6:27 ` Junio C Hamano
2009-05-19 4:16 ` Christian Couder
2009-05-19 5:20 ` Junio C Hamano
2009-05-19 6:35 ` Jakub Narebski
2009-05-19 7:02 ` Miles Bader
2009-05-19 7:14 ` Junio C Hamano
2009-05-19 7:48 ` Jakub Narebski
2009-05-25 9:17 ` Johannes Sixt [this message]
2009-05-25 9:46 ` Johannes Schindelin
2009-05-27 5:12 ` Christian Couder
2009-05-17 15:36 ` [PATCH 3/3] bisect: check ancestors without forking a "git rev-list" process Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1A621E.10703@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).