git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	git@vger.kernel.org, Sam Vilain <sam@vilain.net>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v3 0/3] automatically skip away from broken commits
Date: Tue, 09 Jun 2009 08:25:32 -0700	[thread overview]
Message-ID: <4A2E7EEC.2050807@zytor.com> (raw)
In-Reply-To: <c07716ae0906090526i714bb6c9g4e3d8cf61021af77@mail.gmail.com>

Christian Couder wrote:
> On Tue, Jun 9, 2009 at 6:24 AM, Christian
> Couder<christian.couder@gmail.com> wrote:
>> So I would be ok to implement a config option or a switch to "git
>> bisect start" to let people use a PRNG instead of my algorithm but I
>> think something like my algorithm should be the default.
> 
> Another reason to have 2 algorithms is that when you use "git bisect
> run" you might want to use the PRNG one because:
> 
> - you don't care much if the bisection use some more steps (as long as
> it does not get stuck)
> - you can't do much if it get stuck
> 
> On the other hand, when you bisect manually:
> 
> - you probably won't like it if you are asked to test some commits
> that won't give a lot of information
> - if it get stuck, you can manually use "git bisect visualize" and/or
> "git bisect skip <range>" and/or some other manual commands to do
> something about it
> 

Sort-of-kind-of.  I doubt most users will be able to recover from a
stuck situation, and unless we have extremely high cost of testing
(which is true for some applications) then expecting the user to
optimizing manually is really bad user design.

My main objection to the "skip in goodness space" is exactly the same as
Junio's... it doesn't really buy you what it claims to sell.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

  reply	other threads:[~2009-06-09 17:54 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-06  4:41 [PATCH v3 0/3] automatically skip away from broken commits Christian Couder
2009-06-06  4:41 ` [PATCH v3 1/3] bisect: add parameters to "filter_skipped" Christian Couder
2009-06-06  4:41 ` [PATCH v3 2/3] bisect: when skipping, choose a commit away from a skipped commit Christian Couder
2009-06-06  4:41 ` [PATCH v3 3/3] t6030: test skipping away from an already " Christian Couder
2009-06-06 19:51 ` [PATCH v3 0/3] automatically skip away from broken commits Junio C Hamano
2009-06-07  7:32   ` Christian Couder
2009-06-08  6:06     ` H. Peter Anvin
2009-06-08  7:25       ` Junio C Hamano
2009-06-08 15:51         ` H. Peter Anvin
2009-06-08 21:02           ` Junio C Hamano
2009-06-08 21:10             ` H. Peter Anvin
2009-06-09  4:24             ` Christian Couder
2009-06-09 10:02               ` Jakub Narebski
2009-06-09 15:11                 ` H. Peter Anvin
2009-06-09 21:55                   ` Jakub Narebski
2009-06-09 22:54                     ` H. Peter Anvin
2009-06-09 12:26               ` Christian Couder
2009-06-09 15:25                 ` H. Peter Anvin [this message]
2009-06-09 18:35                   ` Junio C Hamano
2009-06-09 18:42                     ` H. Peter Anvin
2009-06-09 19:28                   ` Christian Couder
2009-06-09 19:32                     ` H. Peter Anvin
2009-06-10  8:14                       ` Christian Couder
2009-06-09 20:37                     ` Junio C Hamano
2009-06-10 19:37                       ` Christian Couder
2009-06-10 21:17                         ` Junio C Hamano
2009-06-10 22:43                           ` H. Peter Anvin
2009-06-11  4:02                           ` Christian Couder
2009-06-11  4:43                             ` H. Peter Anvin
2009-06-11  5:05                               ` H. Peter Anvin
2009-06-12 11:56                                 ` Christian Couder
2009-06-13 19:03                                   ` H. Peter Anvin
2009-06-13 19:35                                     ` Jakub Narebski
2009-06-13 19:57                                       ` H. Peter Anvin
2009-06-15  7:59                                     ` Christian Couder
2009-06-15 13:16                                       ` H. Peter Anvin
2009-06-13  7:50     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2E7EEC.2050807@zytor.com \
    --to=hpa@zytor.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mingo@elte.hu \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).