git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	git@vger.kernel.org, "Jakub Narebski" <jnareb@gmail.com>,
	"Andreas Ericsson" <ae@op5.se>
Subject: Re: [PATCH] format-patch: add --filename-prefix to prepend a prefix to output file names
Date: Sun, 14 Jun 2009 12:46:45 -0700	[thread overview]
Message-ID: <4A3553A5.3060209@gmail.com> (raw)
In-Reply-To: <7vd497qjhm.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Isn't the point of the exercise to come up with something like:
>
>       frotz-0001-first-patch-in-frotz-topic.patch
>       frotz-0002-second-patch-in-frotz-topic.patch
>       frotz-0003-third-patch-in-frotz-topic.patch
>
>       nitfol-0001-first-patch-in-nitfol-topic.patch
>       nitfol-0002-second-patch-in-nitfol-topic.patch
>
> with two invocations of format-patch, and when they are dropped in the
> same directory, the patches from the same series clump together?

Ok. Maybe spelling out the full example in the commit message would be
clearer.

>
> I personally do not think this is worth the additional code (you can
> easily run with --outdir=frotz and then with --outdir=nitfol and obtain
> frotz/000?-*.patch and nitfol/000?-*.patch to get the same clumping) but
> if the convention is to use dash instead of slash, the patch will save one
> step from users.

I agree. How is it any harder to do 'git send-email frotz' instead of
'git send-email frotz-*.patch'? The only advantage I see is you get
attachment filenames with a prefix.

  reply	other threads:[~2009-06-14 19:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 11:33 [PATCH] format-patch: add --prefix to prepend a prefix to output file names Nguyễn Thái Ngọc Duy
2009-06-09 12:37 ` Andreas Ericsson
2009-06-09 23:14   ` Nguyen Thai Ngoc Duy
2009-06-10 10:28   ` [PATCH] format-patch: add --filename-prefix " Nguyễn Thái Ngọc Duy
2009-06-10 10:51     ` Jakub Narebski
2009-06-10 10:56       ` Nguyen Thai Ngoc Duy
2009-06-10 15:58     ` Junio C Hamano
2009-06-14  7:10       ` Nguyễn Thái Ngọc Duy
2009-06-14  8:25         ` Junio C Hamano
2009-06-14  8:29         ` Stephen Boyd
2009-06-14  8:59           ` Junio C Hamano
2009-06-14 19:46             ` Stephen Boyd [this message]
2009-06-14 23:32           ` Nguyen Thai Ngoc Duy
2009-06-09 13:30 ` [PATCH] format-patch: add --prefix " Johannes Sixt
2009-06-09 23:18   ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3553A5.3060209@gmail.com \
    --to=bebarino@gmail.com \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).