From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stephen Boyd <bebarino@gmail.com>, git@vger.kernel.org
Subject: [PATCH] t3700-add: add a POSIXPERM prerequisite to a new test
Date: Mon, 22 Jun 2009 09:30:38 +0200 [thread overview]
Message-ID: <4A3F331E.5080301@viscovery.net> (raw)
In-Reply-To: <4A3A8E73.1010807@gmail.com>
From: Johannes Sixt <j6t@kdbg.org>
The new test does a 'chmod 0', which does not have the intended
effect on Windows.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
Stephen Boyd schrieb:
> Junio C Hamano wrote:
>> Why do you need POSIXPERM for this?
>
> I copied a previous test and it was doing chmod 0 foo2.
...
> +test_expect_success POSIXPERM '--no-ignore-errors overrides config' '
> + git config add.ignore-errors 1 &&
> + git reset --hard &&
> + date >foo1 &&
> + date >foo2 &&
> + chmod 0 foo2 &&
I can only guess that you missed this 'chmod 0' despite Stephen's
explanation and dropped POSIXPERM when you applied the patch.
-- Hannes
t/t3700-add.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 6ae5a2c..85eb0fb 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -223,7 +223,7 @@ test_expect_success POSIXPERM 'git add
'
rm -f foo2
-test_expect_success '--no-ignore-errors overrides config' '
+test_expect_success POSIXPERM '--no-ignore-errors overrides config' '
git config add.ignore-errors 1 &&
git reset --hard &&
date >foo1 &&
--
1.6.3.2.1450.g146e1
next prev parent reply other threads:[~2009-06-22 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 9:17 [PATCH] add: allow configurations to be overriden by command line Stephen Boyd
2009-06-18 16:40 ` Junio C Hamano
2009-06-18 18:14 ` Stephen Boyd
2009-06-18 18:34 ` Junio C Hamano
2009-06-18 18:58 ` Stephen Boyd
2009-06-22 7:30 ` Johannes Sixt [this message]
2009-06-22 7:42 ` [PATCH] t3700-add: add a POSIXPERM prerequisite to a new test Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3F331E.5080301@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).