From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Adam Petaccia <adam@tpetaccia.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add matchings for csharp
Date: Mon, 22 Jun 2009 10:12:18 +0200 [thread overview]
Message-ID: <4A3F3CE2.1070704@gnu.org> (raw)
In-Reply-To: <4A3F238B.1020107@viscovery.net>
>> @@ -79,6 +79,16 @@ PATTERNS("cpp",
>> "|[-+0-9.e]+[fFlL]?|0[xXbB]?[0-9a-fA-F]+[lL]?"
>> "|[-+*/<>%&^|=!]=|--|\\+\\+|<<=?|>>=?|&&|\\|\\||::|->"
>> "|[^[:space:]]|[\x80-\xff]+"),
>> +PATTERNS("csharp",
>> + "!^[ \t]*(catch|do|for|if|instanceof|new|return|switch|throw|while)\n"
>> + "^([ \t]*(static|public|internal|private|protected|new|unsafe|readonly|volatile)[ \t]+(class|enum|interface|struct).*)$\n"
>> + "^([ \t]*(namespace)[ \t]+.*)$"
>
> I think the placement of parentheses could be improved in these two
> expressions (but I don't know for sure because I don't know the code well
> enough). Looking at the other examples in userdiff.c, I infer that the
> *first* opening parentheses defines which part is copied to the hunk
> header.
Yes.
> Since you placed everything into parentheses (unnecessarily, I
> think),
No, not unnecessarily because otherwise only "public" for example would
be copied. I agree though that leading whitespace should not be
included in the parentheses.
Paolo
prev parent reply other threads:[~2009-06-22 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 23:52 [PATCH] Add matchings for csharp Adam Petaccia
2009-06-22 6:24 ` Johannes Sixt
2009-06-22 8:12 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3F3CE2.1070704@gnu.org \
--to=bonzini@gnu.org \
--cc=adam@tpetaccia.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).