From: Johannes Sixt <j.sixt@viscovery.net>
To: Kjetil Barvik <barvik@broadpark.no>
Cc: James Pickens <jepicken@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Alexander Gladysh <agladysh@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Troubles when directory is replaced by symlink
Date: Fri, 26 Jun 2009 16:14:26 +0200 [thread overview]
Message-ID: <4A44D7C2.1060706@viscovery.net> (raw)
In-Reply-To: <868wjf9lxq.fsf@broadpark.no>
Kjetil Barvik schrieb:
> Subject: [PATCH] lstat_cache: guard against full match of length of 'name' parameter
>
> longest_path_match() in symlinks.c does exactly what it's name says,
> but in some cases that match can be too long, since the
> has_*_leading_path() functions assumes that the match will newer be as
> long as the name string given to the function.
And these "some cases" are? When "a directory was replaced by a symlink"
("or what??" I am inclined to add). Would you please be very specific
here, perhaps with an example, so that we still know the details in 6 months.
> +test_expect_success 'checkout of master - alpha/file and beta/alpha/file should exist' '
test_expect_success 'checkout replaces symlink by directory' '
BTW, this is what the test seems to check, and it is the opposite of what
the mail's Subject says. So, which one is it?
> +
> + git checkout master &&
> + ls alpha/file beta/alpha/file
git checkout master &&
! test -h alpha &&
test -f alpha/file &&
test -f beta/alpha/file
-- Hannes
prev parent reply other threads:[~2009-06-26 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:43 Troubles when directory is replaced by symlink Alexander Gladysh
2009-06-09 8:18 ` Alexander Gladysh
2009-06-11 11:48 ` Jeff King
2009-06-11 14:37 ` Kjetil Barvik
2009-06-14 14:34 ` Kjetil Barvik
2009-06-24 22:07 ` James Pickens
2009-06-25 22:51 ` Kjetil Barvik
2009-06-26 13:14 ` Kjetil Barvik
2009-06-26 14:14 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A44D7C2.1060706@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=agladysh@gmail.com \
--cc=barvik@broadpark.no \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jepicken@gmail.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).