git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2009, #01; Mon, 06)
Date: Tue, 07 Jul 2009 22:39:34 -0700	[thread overview]
Message-ID: <4A543116.8050507@gmail.com> (raw)
In-Reply-To: <7vk52l4q7k.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> For the following three series, I have not managed to convince myself if
> these changes have real-world needs.
>
> * sb/read-tree (Thu Jun 25 22:14:10 2009 -0700) 2 commits
>  - read-tree: migrate to parse-options
>  - read-tree: convert unhelpful usage()'s to helpful die()'s

I think the first patch is good. I am still thinking about the second
one though. Obviously rc is coming so it's not too pressing.

I've done a quick survey of parse-optification of builtins and I see
that send-pack, rev-list, and fetch-pack all set bitfields when parsing
options. Migrating these will have the same problems. I don't know if
there's really any simple answer to it though, because you can't take
the address of a bitfield. And I think it's stupid to make the bitfields
into full ints just to support parse-options.

Maybe some builtins are just never meant to be migrated. Like
update-index and its --cacheinfo option.

  parent reply	other threads:[~2009-07-08  5:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 18:32 What's cooking in git.git (Jul 2009, #01; Mon, 06) Junio C Hamano
2009-07-06 20:29 ` Marcus Camen
2009-07-06 21:38   ` Junio C Hamano
2009-07-06 22:03     ` Marcus Camen
2009-07-06 22:34       ` Junio C Hamano
2009-07-06 23:42 ` Jakub Narebski
2009-07-07  2:18 ` Mark Lodato
2009-07-07 21:11   ` Jeff King
2009-07-07  6:30 ` Johannes Sixt
2009-07-07 19:17 ` Linus Torvalds
2009-07-07 19:57   ` Alex Riesen
2009-07-07 22:13     ` Linus Torvalds
2009-07-07 20:08 ` Johannes Schindelin
2009-07-07 20:13   ` Shawn O. Pearce
2009-07-07 22:19     ` Junio C Hamano
2009-07-07 22:28       ` Shawn O. Pearce
2009-07-08 13:42         ` notes, was " Johannes Schindelin
2009-07-08  5:39 ` Stephen Boyd [this message]
2009-07-08  6:38 ` Johannes Sixt
2009-07-10  5:05 ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A543116.8050507@gmail.com \
    --to=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).