From: Johannes Sixt <j.sixt@viscovery.net>
To: Johan Herland <johan@herland.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Peter Krefting <peter@softwolves.pp.se>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] quickfetch(): Prevent overflow of the rev-list command line
Date: Thu, 09 Jul 2009 10:51:20 +0200 [thread overview]
Message-ID: <4A55AF88.3090205@viscovery.net> (raw)
In-Reply-To: <200907091043.03263.johan@herland.net>
Johan Herland schrieb:
> Does anybody with Windows/MSYS experience know how this scenario (write() to
> a terminated process, followed by close()) would play out in msysGit?
The first write() sometimes fails with EPIPE, otherwise it fails with
EINVAL. All subsequent write()s fail with EINVAL. The setting of SIGPIPE
is irrelevant because it is unknown to Windows.
There's precedent already in write_or_die.c. You should not write the
error message for both EPIPE and EINVAL.
-- Hannes
next prev parent reply other threads:[~2009-07-09 8:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 13:10 msysgit git-submodule: "Unable to fetch in submodule path ..." Peter Krefting
2009-06-22 12:46 ` Peter Krefting
2009-07-08 13:58 ` [PATCH] quickfetch(): Prevent overflow of the rev-list command line Johan Herland
2009-07-08 15:12 ` Johannes Sixt
2009-07-08 16:01 ` Johan Herland
2009-07-08 17:22 ` Junio C Hamano
2009-07-09 8:43 ` Johan Herland
2009-07-09 8:49 ` Alex Riesen
2009-07-09 8:51 ` Johannes Sixt [this message]
2009-07-09 9:07 ` Johan Herland
2009-07-09 9:15 ` Johannes Sixt
2009-07-09 9:34 ` Johan Herland
2009-07-09 12:22 ` Johannes Sixt
2009-07-09 13:52 ` [PATCH v3] " Johan Herland
2009-07-09 14:21 ` Johannes Sixt
2009-07-09 14:32 ` Jeff King
2009-07-09 14:49 ` [PATCH v4] " Johan Herland
2009-07-09 16:20 ` Johannes Sixt
2009-07-09 23:52 ` [PATCH v5] " Johan Herland
2009-07-11 6:55 ` Junio C Hamano
2009-07-11 10:58 ` Johan Herland
2009-07-09 14:42 ` [PATCH v3] " Johan Herland
2009-07-09 14:56 ` Johannes Sixt
2009-07-09 15:32 ` Johan Herland
2009-07-09 16:14 ` Johannes Sixt
2009-07-09 8:01 ` [PATCH] " Alex Riesen
2009-07-09 8:37 ` Johan Herland
2009-07-09 8:43 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A55AF88.3090205@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=peter@softwolves.pp.se \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).