From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, git@vger.kernel.org
Subject: Re: [PATCH] Re: Make 'git show' more useful
Date: Tue, 14 Jul 2009 08:25:02 +0200 [thread overview]
Message-ID: <4A5C24BE.4090804@gnu.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0907140324140.3155@pacific.mpi-cbg.de>
>> The actual "--no-walk" flag was then added over a year later by Dsco, in
>> commit 8e64006eee ("Teach revision machinery about --no-walk").
>>
>> Doing a "git log -p -S--no-walk", I have to admit that I don't find a
>> single actual _use_ of --no-walk.
>
> Actually, I remember very precisely why I introduced it. The difference
> between "git log --no-walk a b c" and "git show a b c" is that "git log"
> sorts the commits by commit time, which is pretty important in my case.
Very nice. Can you add a test for that?
(OTOH do-walk seems to be superseded by Linus's patch).
Paolo
next prev parent reply other threads:[~2009-07-14 6:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 21:41 Make 'git show' more useful Linus Torvalds
2009-07-13 22:11 ` Junio C Hamano
2009-07-13 23:43 ` [PATCH] " Paolo Bonzini
2009-07-14 0:00 ` Linus Torvalds
2009-07-14 1:25 ` Johannes Schindelin
2009-07-14 1:47 ` Linus Torvalds
2009-07-14 6:25 ` Paolo Bonzini [this message]
2009-07-14 10:44 ` Johannes Schindelin
2009-07-14 12:08 ` [PATCH] t4202-log.sh: Test git log --no-walk sort order Michael J Gruber
2009-07-14 12:21 ` Johannes Sixt
2009-07-14 12:38 ` Michael J Gruber
2009-07-14 12:45 ` [PATCHv2] " Michael J Gruber
2009-07-14 14:13 ` Johannes Schindelin
2009-07-14 14:28 ` Michael J Gruber
2009-07-17 14:28 ` [PATCH] " Michael J Gruber
2009-07-17 14:53 ` Johannes Schindelin
2009-07-13 23:42 ` Make 'git show' more useful Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5C24BE.4090804@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).