git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Re: git-am: less strong format "mbox" detection
Date: Tue, 14 Jul 2009 10:35:58 +0200	[thread overview]
Message-ID: <4A5C436E.8000304@viscovery.net> (raw)
In-Reply-To: <20090714082059.GA13808@vidovic>

Nicolas Sebrecht schrieb:
> Le 14/07/09, Giuseppe Bilotta a écrit :
> 
>>> diff --git a/git-am.sh b/git-am.sh
>>> index d64d997..d10a8e0 100755
>>> --- a/git-am.sh
>>> +++ b/git-am.sh
>>> @@ -169,7 +169,7 @@ check_patch_format () {
>>>                read l2
>>>                read l3
>>>                case "$l1" in
>>> -               "From "* | "From: "*)
>>> +               "From "* | "From: "* | "X-Account-Key:"* | "Return-Path:"* | "Delivered-To:"*)
> 
> And why should we accept "From "?

Because mbox format must begin with "From ".

The question is rather: Why should we accept anything else? The case arm
in question is about detecting mbox format.

-- Hannes

  reply	other threads:[~2009-07-14  8:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  6:40 [PATCH] git-am: less strong format "mbox" detection Nicolas Sebrecht
2009-07-14  7:16 ` Giuseppe Bilotta
2009-07-14  8:20   ` [PATCH] " Nicolas Sebrecht
2009-07-14  8:35     ` Johannes Sixt [this message]
2009-07-14  8:42     ` Junio C Hamano
2009-07-14 12:23       ` Nicolas Sebrecht
2009-07-15  5:52         ` [PATCH v2] git-am: fix maildir support regression for unordered headers in emails Nicolas Sebrecht
2009-07-15  7:27           ` Junio C Hamano
2009-07-15 12:54             ` Derek Fawcus
2009-07-15 16:19               ` [PATCH v2] " Nicolas Sebrecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5C436E.8000304@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=nicolas.s.dev@gmx.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).