git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] push: add --current
Date: Sun, 19 Jul 2009 23:46:38 +0200	[thread overview]
Message-ID: <4A63943E.80209@gnu.org> (raw)
In-Reply-To: <20090720063244.6117@nanako3.lavabit.com>

Thanks for the review!

> If your final belief (which I happen to agree) is that
> 
> % git push --current
> % git push --current origin
> % git push --current over.there.example.com:project.git
> 
> should work as expected [...] mark clearly that the code after this patch is still broken

Okay, will do.  I just wanted to present both possibilities and thought
that (succeeding) tests were the best way to illustrate the difference.
 For the final submission, now that I had a second opinion, I'll
probably just squash 1/3 and 2/3 together.

> The style of the existing tests in the script isn't
> 
> 	test `git rev-parse master` = `cd b.git && git rev-parse master`
> 
> but is
> 
> 	test "$(git rev-parse master)" = "$(cd b.git && git rev-parse master)"

Will do.

Paolo

  reply	other threads:[~2009-07-19 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13 23:07 [PATCH 0/3]: add git push --current and remote.*.pushHeadOnly Paolo Bonzini
2009-07-13 23:07 ` [PATCH 1/3] push: add --current Paolo Bonzini
2009-07-19 21:32   ` Nanako Shiraishi
2009-07-19 21:46     ` Paolo Bonzini [this message]
2009-07-13 23:07 ` [PATCH 2/3] change default push refspec when --current is given Paolo Bonzini
2009-07-13 23:07 ` [PATCH 3/3] push: add remote.*.pushHeadOnly configuration Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A63943E.80209@gnu.org \
    --to=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).