git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <paolo.bonzini@gmail.com>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Paolo Bonzini <bonzini@gnu.org>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/3] push: add --current
Date: Mon, 20 Jul 2009 11:48:43 +0200	[thread overview]
Message-ID: <4A643D7B.9090900@gmail.com> (raw)
In-Reply-To: <20090720071413.GA29915@atjola.homenet>

>> +--current::
>> +	Independent of the other options, restrict pushing to the current
>> +	HEAD.
>
> To me, this sounds like there are multiple HEADs and this selects the
> current one to be pushed, which would be wrong. Maybe this could be
> written as:
>
> 	Restrict pushing to the currently checked out branch head.

I wrote that referring to "the branch currently pointed to by [the 
symref] HEAD".

> Hm, this only talks about refspecs in the config, but your patch series
> is especially about push.default=tracking, which is not a refspec set in
> the config, but causes a refspec to be generated on the fly.

Not really, as push.default=tracking and push.default=current would 
anyway push only the currently checked out branch.  "git push --current" 
would have a visible effect only for push.default=matching (the effect 
would be the same as push.default=current except that a new branch will 
not be created remotely).

If you have creted all your tracking branches with autosetuppush, then 
in that case "git push --current" or pushHeadOnly will indeed achieve 
the same effect as push.default=tracking; however, that would be with 
real refspecs in the config rather than with one generated on the fly. 
And since in that case you have a push refspec in the configuration, 
push.default would not be used.

Paolo

  reply	other threads:[~2009-07-20  9:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-20  6:36 [PATCH 0/3] add push --current and remote.*.pushHeadOnly Paolo Bonzini
2009-07-20  6:36 ` [PATCH 1/3] reintroduce PUSH_DEFAULT_UNSPECIFIED Paolo Bonzini
2009-07-20  6:36 ` [PATCH 2/3] push: add --current Paolo Bonzini
2009-07-20  7:14   ` Björn Steinbrink
2009-07-20  9:48     ` Paolo Bonzini [this message]
2009-07-20 10:15   ` Tay Ray Chuan
2009-07-20 11:50     ` Paolo Bonzini
2009-07-20 11:17   ` demerphq
2009-07-20  6:37 ` [PATCH 3/3] push: add remote.*.pushHeadOnly configuration Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2009-07-20 11:58 [PATCH v3 0/3] add push --current and remote.*.pushHeadOnly Paolo Bonzini
2009-07-20 11:58 ` [PATCH 2/3] push: add --current Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A643D7B.9090900@gmail.com \
    --to=paolo.bonzini@gmail.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).