From: Paolo Bonzini <bonzini@gnu.org>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/3] push: add --current
Date: Mon, 20 Jul 2009 13:50:53 +0200 [thread overview]
Message-ID: <4A645A1D.8010401@gnu.org> (raw)
In-Reply-To: <be6fef0d0907200315j14089edcv8baa997d2ec34f3f@mail.gmail.com>
On 07/20/2009 12:15 PM, Tay Ray Chuan wrote:
> Hi,
>
> On Mon, Jul 20, 2009 at 2:36 PM, Paolo Bonzini<bonzini@gnu.org> wrote:
>> t/t5516-fetch-push.sh | 50 ++++++++++++++++++++++++++++++++++++++++++++
>
> since you're making modifications to pushing over HTTP, you should
> consider making tests also for HTTP repositories, or else your changes
> in http-push.c won't be used.
Yeah, I had tested them with a server I already had setup rather than
with the testsuite, because the default Apache setup of Fedora is not
detected correctly by lib-httpd.sh. Any test I included would then be
untested, while http-push.c was tested. :-)
However, I'll include the tests in v3 of the patch.
Paolo
next prev parent reply other threads:[~2009-07-20 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 6:36 [PATCH 0/3] add push --current and remote.*.pushHeadOnly Paolo Bonzini
2009-07-20 6:36 ` [PATCH 1/3] reintroduce PUSH_DEFAULT_UNSPECIFIED Paolo Bonzini
2009-07-20 6:36 ` [PATCH 2/3] push: add --current Paolo Bonzini
2009-07-20 7:14 ` Björn Steinbrink
2009-07-20 9:48 ` Paolo Bonzini
2009-07-20 10:15 ` Tay Ray Chuan
2009-07-20 11:50 ` Paolo Bonzini [this message]
2009-07-20 11:17 ` demerphq
2009-07-20 6:37 ` [PATCH 3/3] push: add remote.*.pushHeadOnly configuration Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2009-07-20 11:58 [PATCH v3 0/3] add push --current and remote.*.pushHeadOnly Paolo Bonzini
2009-07-20 11:58 ` [PATCH 2/3] push: add --current Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A645A1D.8010401@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).